[ 
https://issues.apache.org/jira/browse/HADOOP-10356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535202#comment-14535202
 ] 

Arpit Agarwal commented on HADOOP-10356:
----------------------------------------

+1 for the patch. Thanks for fixing this [~René Nyffenegger] and thanks for the 
review and verification [~kiranmr].

I will commit it shortly.

> Corrections in winutils/chmod.c
> -------------------------------
>
>                 Key: HADOOP-10356
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10356
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: bin
>         Environment: Windows
>            Reporter: René Nyffenegger
>            Assignee: René Nyffenegger
>            Priority: Trivial
>              Labels: BB2015-05-RFC
>         Attachments: HADOOP-10356.patch
>
>
> There are two small things in winutils/chmod.c:
>   pathName should be pointer to a constant WSTR
>   the declartion
>       LPWSTR pathName = NULL;
>   seems to be wrong.
>         LPCWSTR pathName = NULL;
>    should b used instead.
>   ------------------------------------------------
>    I believe the fragment
>       switch (c)
>       {
>       case NULL:
>    to be wrong as pointers are not permitted as
>    case values.
>   ------------------------------------------------



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to