[ 
https://issues.apache.org/jira/browse/HADOOP-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535381#comment-14535381
 ] 

Hadoop QA commented on HADOOP-11906:
------------------------------------

\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | reexec |   0m  0s | dev-support patch detected. |
| {color:blue}0{color} | pre-patch |   0m  0s | Pre-patch trunk compilation is 
healthy. |
| {color:blue}0{color} | @author |   0m  0s | Skipping @author checks as 
test-patch has been patched. |
| {color:green}+1{color} | release audit |   0m 15s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:green}+1{color} | shellcheck |   0m  5s | There were no new shellcheck 
(v0.3.3) issues. |
| {color:green}+1{color} | whitespace |   0m  1s | The patch has no lines that 
end in whitespace. |
| | |   0m 24s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12731503/HADOOP-11906.1.patch |
| Optional Tests | shellcheck |
| git revision | trunk / 8f7c236 |
| Java | 1.7.0_55 |
| uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6551/console |


This message was automatically generated.

> test-patch.sh should use 'file' command for patch determinism
> -------------------------------------------------------------
>
>                 Key: HADOOP-11906
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11906
>             Project: Hadoop Common
>          Issue Type: Test
>            Reporter: Allen Wittenauer
>            Assignee: Sean Busbey
>         Attachments: HADOOP-11906.1.patch
>
>
> test-patch.sh currently restricts patches to the extension .patch.  It might 
> be useful to also check if the file command says it is a diff.  This would 
> allow us to determine if files that end in .txt are actually patches.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to