[
https://issues.apache.org/jira/browse/HADOOP-11887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535553#comment-14535553
]
Kai Zheng commented on HADOOP-11887:
------------------------------------
Thanks Colin for the comments. I'll update the patch following the good ideas.
Just to make sure before proceed:
bq. Suggest renaming this simply to LOAD_DYNAMIC_SYMBOL
I used a different name in order to avoid conflict with the one defined in
{{org_apache_hadoop.h}}, though I thought it should be ok to re-define the
macro locally in the file. So yes I will simply rename the macro name to
LOAD_DYNAMIC_SYMBOL.
bq. Do you want to add the new unit test to the set of native unit tests?
It's a good idea and why not. The test codes should be conditionally run into
regarding the ISA-L library available or not, and there are two ways:
1) Run the executable anyway, but if ISA-L not available and loading it failed,
the test program exits 0 (maybe reporting a warning message?). Easier to do
this in the c program.
2) Check the library first, if not available, then not execute the test program
at all. Not clear to me yet how to do this in pom.xml.
Would you suggest and help? Thanks.
> Introduce Intel ISA-L erasure coding library for the native support
> -------------------------------------------------------------------
>
> Key: HADOOP-11887
> URL: https://issues.apache.org/jira/browse/HADOOP-11887
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: io
> Reporter: Kai Zheng
> Assignee: Kai Zheng
> Attachments: HADOOP-11887-v1.patch, HADOOP-11887-v2.patch
>
>
> This is to introduce Intel ISA-L erasure coding library for the native
> support, via dynamic loading mechanism (dynamic module, like *.so in *nix and
> *.dll on Windows).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
