[
https://issues.apache.org/jira/browse/HADOOP-9159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535679#comment-14535679
]
Yongjun Zhang commented on HADOOP-9159:
---------------------------------------
Good question to ask [~szetszwo], thanks.
Hi [~thejas], would you please address Nicholas' question? thanks.
Hi [~brandonli], thanks for the patch, changes look good if Nicholas' question
is answered. Minor comments:
1. Test failure need to be addressed:
{code}
checkInvalidPath: har://127.0.0.1/foo.har
2015-05-08 02:44:34,517 ERROR fs.TestHarFileSystem
(TestHarFileSystem.java:testInheritedMethodsImplemented(347)) - HarFileSystem
MUST implement public boolean
org.apache.hadoop.fs.FileSystem.equals(java.lang.Object)
2015-05-08 02:44:34,517 ERROR fs.TestHarFileSystem
(TestHarFileSystem.java:testInheritedMethodsImplemented(347)) - HarFileSystem
MUST implement public int org.apache.hadoop.fs.FileSystem.hashCode()
{code}
2. Three white spaces to be removed:
https://builds.apache.org/job/PreCommit-HADOOP-Build/6438/artifact/patchprocess/whitespace.txt
3. The size of file FileSystem.java exceeded some configured limit, per
https://builds.apache.org/job/PreCommit-HADOOP-Build/6547/artifact/patchprocess/diffcheckstylehadoop-common.txt
we may need to increase the limit to remove that warning. But not a real issue
here.
Thanks.
> FileSystem class should override .equals(Object)
> ------------------------------------------------
>
> Key: HADOOP-9159
> URL: https://issues.apache.org/jira/browse/HADOOP-9159
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 1.1.1, 3.0.0
> Reporter: Thejas M Nair
> Assignee: Brandon Li
> Attachments: HADOOP-9159.patch, HADOOP-9159.patch
>
>
> The FileSystem class has a notion of equality, based on the uri. The class
> should override .equal(Object) so that it returns true if FileSystem objects
> are logically same.
> This is useful when FileSystem cache is disabled, as FileSystem.get(..) will
> return new object each time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
