[
https://issues.apache.org/jira/browse/HADOOP-11597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14536260#comment-14536260
]
Yongjun Zhang commented on HADOOP-11597:
----------------------------------------
Hi [~szetszwo],
Thanks for the clarification of your suggestion, I was confused earlier because
I thought you meant to take the OSType out from Shell: "It is good to refactor
OSType out from Shell. How about simply moving OSType to a standalone class
instead of adding CurrentOS?"
I like your suggestion and thanks for that. I did a new rev to address it. One
problem of having an OSType outside Shell is, when both this OSType and Shell
are imported in a file, this OSType conflicts with the one in Shell (we kept
the one in Shell for backward compatibility). Thus in stead of calling OSType,
I made it OsType, I think you mentioned that you prefer this kind of naming
too.
It's a bit confusing to have OsType and OSType in the code base because they
differ by only the "case" of a letter, but our eventual goal is to obsolete
OSType in Shell, I guess it's ok. I changed all reference of Shell.WINDOWS in
hadoop-common to OsType.IS_WINDOWS in the patch. The goal is to do the same for
all other components in related jiras.
HI [~cmccabe], [~steve_l] and [~cnauroth],
Thanks for your earlier review. I got Nicholas' help during the bug bash. I'm
uploading patch rev 4 to address his suggestion: I changed {{class CurrentOS}}
to {{enum OsType}} and made it {{@InterfaceStability.Unstable}} instead of
{{@InterfaceStability.Evolving}}. Would you please comment if you have any?
Thank you all.
> Factor OSType out from Shell: change in common
> ----------------------------------------------
>
> Key: HADOOP-11597
> URL: https://issues.apache.org/jira/browse/HADOOP-11597
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: util
> Affects Versions: 2.7.0
> Reporter: Yongjun Zhang
> Assignee: Yongjun Zhang
> Labels: BB2015-05-TBR
> Attachments: HADOOP-11597.001.patch, HADOOP-11597.002.patch,
> HADOOP-11597.003.patch
>
>
> This jira is to cover the hadoop-common-project change for HADOOP-11293
> (Factor OSType out from Shell).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
