[ 
https://issues.apache.org/jira/browse/HADOOP-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539008#comment-14539008
 ] 

Hadoop QA commented on HADOOP-11393:
------------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  17m 34s | Pre-patch trunk compilation is 
healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to 
include 4 new or modified test files. |
| {color:green}+1{color} | javac |   7m 28s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |   9m 34s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 22s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:green}+1{color} | site |   3m  0s | Site still builds. |
| {color:red}-1{color} | checkstyle |   5m 57s | The applied patch generated  1 
new checkstyle issues (total was 18, now 18). |
| {color:red}-1{color} | checkstyle |   6m 45s | The applied patch generated  2 
new checkstyle issues (total was 160, now 156). |
| {color:green}+1{color} | shellcheck |   0m  5s | There were no new shellcheck 
(v0.3.3) issues. |
| {color:red}-1{color} | whitespace |   0m  5s | The patch has 4  line(s) that 
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install |   1m 37s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 32s | The patch built with 
eclipse:eclipse. |
| {color:red}-1{color} | findbugs |  10m 41s | The patch appears to introduce 2 
new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | common tests |  23m 13s | Tests passed in 
hadoop-common. |
| {color:green}+1{color} | common tests |   1m 37s | Tests passed in 
hadoop-kms. |
| {color:green}+1{color} | mapreduce tests |   1m 33s | Tests passed in 
hadoop-mapreduce-client-core. |
| {color:green}+1{color} | mapreduce tests | 102m 49s | Tests passed in 
hadoop-mapreduce-client-jobclient. |
| {color:green}+1{color} | tools/hadoop tests |   0m 27s | Tests passed in 
hadoop-datajoin. |
| {color:green}+1{color} | tools/hadoop tests |   0m 57s | Tests passed in 
hadoop-sls. |
| {color:green}+1{color} | tools/hadoop tests |   6m 12s | Tests passed in 
hadoop-streaming. |
| {color:green}+1{color} | yarn tests |   6m  4s | Tests passed in 
hadoop-yarn-server-nodemanager. |
| {color:red}-1{color} | hdfs tests | 164m 43s | Tests failed in hadoop-hdfs. |
| {color:red}-1{color} | hdfs tests |  13m 14s | Tests failed in 
hadoop-hdfs-httpfs. |
| | | 378m 57s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-datajoin |
|  |  Unread public/protected field:At DataJoinMapperBase.java:[line 52] |
|  |  Unread public/protected field:At DataJoinMapperBase.java:[line 50] |
| Failed unit tests | hadoop.tracing.TestTraceAdmin |
|   | hadoop.hdfs.tools.TestHdfsConfigFields |
|   | hadoop.fs.http.client.TestHttpFSWithHttpFSFileSystem |
|   | hadoop.fs.http.client.TestHttpFSFWithWebhdfsFileSystem |
|   | hadoop.fs.http.client.TestHttpFSFWithSWebhdfsFileSystem |
| Timed out tests | 
org.apache.hadoop.fs.http.client.TestHttpFSFileSystemLocalFileSystem |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12731641/HADOOP-11393.01.patch |
| Optional Tests | javadoc javac unit shellcheck site findbugs checkstyle |
| git revision | trunk / b9cebfc |
| checkstyle |  
https://builds.apache.org/job/PreCommit-HADOOP-Build/6589/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-core.txt
 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6589/artifact/patchprocess/diffcheckstylehadoop-streaming.txt
 |
| whitespace | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6589/artifact/patchprocess/whitespace.txt
 |
| Findbugs warnings | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6589/artifact/patchprocess/newPatchFindbugsWarningshadoop-datajoin.html
 |
| hadoop-common test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6589/artifact/patchprocess/testrun_hadoop-common.txt
 |
| hadoop-kms test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6589/artifact/patchprocess/testrun_hadoop-kms.txt
 |
| hadoop-mapreduce-client-core test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6589/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt
 |
| hadoop-mapreduce-client-jobclient test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6589/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt
 |
| hadoop-datajoin test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6589/artifact/patchprocess/testrun_hadoop-datajoin.txt
 |
| hadoop-sls test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6589/artifact/patchprocess/testrun_hadoop-sls.txt
 |
| hadoop-streaming test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6589/artifact/patchprocess/testrun_hadoop-streaming.txt
 |
| hadoop-yarn-server-nodemanager test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6589/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
 |
| hadoop-hdfs test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6589/artifact/patchprocess/testrun_hadoop-hdfs.txt
 |
| hadoop-hdfs-httpfs test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6589/artifact/patchprocess/testrun_hadoop-hdfs-httpfs.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6589/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6589/console |


This message was automatically generated.

> Revert HADOOP_PREFIX, go back to HADOOP_HOME
> --------------------------------------------
>
>                 Key: HADOOP-11393
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11393
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>              Labels: BB2015-05-TBR
>         Attachments: HADOOP-11393-00.patch, HADOOP-11393.01.patch
>
>
> Today, Windows and parts of the Hadoop source code still use HADOOP_HOME.  
> The switch to HADOOP_PREFIX back in 0.21 or so didn't really accomplish what 
> it was intended to do and only helped confuse the situation.
> _HOME is a much more standard suffix and is, in fact, used for everything in 
> Hadoop except for the top level project home.  I think it would be beneficial 
> to use HADOOP_HOME in the shell code as the Official(tm) variable, still 
> honoring HADOOP_PREFIX if it is set.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to