[ 
https://issues.apache.org/jira/browse/HADOOP-11969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544690#comment-14544690
 ] 

Hadoop QA commented on HADOOP-11969:
------------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  14m 39s | Pre-patch trunk compilation is 
healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to 
include 3 new or modified test files. |
| {color:green}+1{color} | javac |   7m 33s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |   9m 36s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 23s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   3m 31s | There were no new checkstyle 
issues. |
| {color:green}+1{color} | whitespace |   0m  1s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | install |   1m 35s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   5m 23s | The patch does not introduce 
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | common tests |  23m 44s | Tests passed in 
hadoop-common. |
| {color:green}+1{color} | common tests |   1m 37s | Tests passed in 
hadoop-kms. |
| {color:green}+1{color} | mapreduce tests |   1m 34s | Tests passed in 
hadoop-mapreduce-client-core. |
| {color:green}+1{color} | tools/hadoop tests |   6m  6s | Tests passed in 
hadoop-distcp. |
| {color:green}+1{color} | tools/hadoop tests |   6m  9s | Tests passed in 
hadoop-streaming. |
| {color:red}-1{color} | hdfs tests |   3m 19s | Tests failed in 
hadoop-hdfs-httpfs. |
| | |  85m 48s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.fs.http.client.TestHttpFSWithHttpFSFileSystem |
|   | hadoop.fs.http.client.TestHttpFSFWithWebhdfsFileSystem |
|   | hadoop.fs.http.client.TestHttpFSFWithSWebhdfsFileSystem |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12732990/HADOOP-11969.4.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 53fe4ef |
| hadoop-common test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6697/artifact/patchprocess/testrun_hadoop-common.txt
 |
| hadoop-kms test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6697/artifact/patchprocess/testrun_hadoop-kms.txt
 |
| hadoop-mapreduce-client-core test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6697/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt
 |
| hadoop-distcp test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6697/artifact/patchprocess/testrun_hadoop-distcp.txt
 |
| hadoop-streaming test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6697/artifact/patchprocess/testrun_hadoop-streaming.txt
 |
| hadoop-hdfs-httpfs test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6697/artifact/patchprocess/testrun_hadoop-hdfs-httpfs.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6697/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6697/console |


This message was automatically generated.

> ThreadLocal initialization in several classes is not thread safe
> ----------------------------------------------------------------
>
>                 Key: HADOOP-11969
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11969
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Critical
>              Labels: thread-safety
>         Attachments: HADOOP-11969.1.patch, HADOOP-11969.2.patch, 
> HADOOP-11969.3.patch, HADOOP-11969.4.patch
>
>
> Right now, the initialization of hte thread local factories for encoder / 
> decoder in Text are not marked final. This means they end up with a static 
> initializer that is not guaranteed to be finished running before the members 
> are visible. 
> Under heavy contention, this means during initialization some users will get 
> an NPE:
> {code}
> (2015-05-05 08:58:03.974 : solr_server_log.log) 
>  org.apache.solr.common.SolrException; null:java.lang.NullPointerException
>       at org.apache.hadoop.io.Text.decode(Text.java:406)
>       at org.apache.hadoop.io.Text.decode(Text.java:389)
>       at org.apache.hadoop.io.Text.toString(Text.java:280)
>       at org.apache.hadoop.hdfs.protocolPB.PBHelper.convert(PBHelper.java:764)
>       at 
> org.apache.hadoop.hdfs.protocol.datatransfer.DataTransferProtoUtil.buildBaseHeader(DataTransferProtoUtil.java:81)
>       at 
> org.apache.hadoop.hdfs.protocol.datatransfer.DataTransferProtoUtil.buildClientHeader(DataTransferProtoUtil.java:71)
>       at 
> org.apache.hadoop.hdfs.protocol.datatransfer.Sender.readBlock(Sender.java:101)
>       at 
> org.apache.hadoop.hdfs.RemoteBlockReader2.newBlockReader(RemoteBlockReader2.java:400)
>       at 
> org.apache.hadoop.hdfs.BlockReaderFactory.getRemoteBlockReader(BlockReaderFactory.java:785)
>       at 
> org.apache.hadoop.hdfs.BlockReaderFactory.getRemoteBlockReaderFromTcp(BlockReaderFactory.java:663)
>       at 
> org.apache.hadoop.hdfs.BlockReaderFactory.build(BlockReaderFactory.java:327)
>       at 
> org.apache.hadoop.hdfs.DFSInputStream.actualGetFromOneDataNode(DFSInputStream.java:1027)
>       at 
> org.apache.hadoop.hdfs.DFSInputStream.fetchBlockByteRange(DFSInputStream.java:974)
>       at org.apache.hadoop.hdfs.DFSInputStream.read(DFSInputStream.java:1305)
>       at org.apache.hadoop.fs.FSInputStream.readFully(FSInputStream.java:78)
>       at 
> org.apache.hadoop.fs.FSDataInputStream.readFully(FSDataInputStream.java:107)
> ... SNIP...
> {code} 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to