[
https://issues.apache.org/jira/browse/HADOOP-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14546429#comment-14546429
]
Jing Zhao commented on HADOOP-1540:
-----------------------------------
The patch looks pretty good to me. Just some minors:
# In {{RegexCopyFilter}} and {{TrueCopyFilter}}, please make sure "@Override"
annotation is added for overrided methods. Besides, "inheritDoc" is actually
unnecessary unless there is extra javadoc added.
# {{RegexCopyFilter}}'s constructor can take the file name as the parameter
instead of the Configuration object.
# {{RegexCopyFilter}}'s default constructor can be removed. For test we can
pass a string to its constructor.
# The parameter "options" can removed from
{{SimpleCopyListing#writeToFileListing}}.
> distcp should support an exclude list
> -------------------------------------
>
> Key: HADOOP-1540
> URL: https://issues.apache.org/jira/browse/HADOOP-1540
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 2.6.0
> Reporter: Senthil Subramanian
> Assignee: Rich Haase
> Priority: Minor
> Labels: BB2015-05-TBR, patch
> Attachments: HADOOP-1540.008.patch
>
>
> There should be a way to ignore specific paths (eg: those that have already
> been copied over under the current srcPath).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
