[
https://issues.apache.org/jira/browse/HADOOP-11991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14548147#comment-14548147
]
Akira AJISAKA commented on HADOOP-11991:
----------------------------------------
Thanks [~sekikn] for the clarification and updating the patch. Mostly looks
good to me.
{code}
-## @description If this patches actually patches test-patch.sh, then
+## @description If this patches actually patches test-patch.sh,
smart-apply-patch.sh or the files under test-patch.d, then
## @description run with the patched version for the test.
{code}
Minor nit: Would you render the line within 80 characters?
> test-patch.sh isn't re-executed even if smart-apply-patch.sh is modified
> ------------------------------------------------------------------------
>
> Key: HADOOP-11991
> URL: https://issues.apache.org/jira/browse/HADOOP-11991
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Reporter: Kengo Seki
> Assignee: Kengo Seki
> Attachments: HADOOP-11991.001.patch, HADOOP-11991.002.patch
>
>
> I think this condition is wrong.
> {code}
> if [[ ! ${CHANGED_FILES} =~ dev-support/test-patch
> || ${CHANGED_FILES} =~ dev-support/smart-apply ]] ; then
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
