[
https://issues.apache.org/jira/browse/HADOOP-11910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14548313#comment-14548313
]
Allen Wittenauer commented on HADOOP-11910:
-------------------------------------------
It occurred to me that the logic for determining the branch could be made much
simpler. sed out '.txt' and '.patch'. Then that part of the code can drop a
few cases and make better assumptions about where a version string is hiding.
This doesn't help the generic case though: if someone passes in that .diff is
ok for the patch re, how does the determine branch code work? Maybe this
should get changed from "allow this RE" to "allow these extra extensions".
> add command line arg to test-patch for the regex to use for evaluating if
> something is a patch file.
> ----------------------------------------------------------------------------------------------------
>
> Key: HADOOP-11910
> URL: https://issues.apache.org/jira/browse/HADOOP-11910
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Labels: BB2015-05-TBR
> Attachments: HADOOP-11910.1.patch, HADOOP-11910.2.patch,
> HADOOP-11910.2.patch
>
>
> right now before test-patch can be used on a submission it checks if the file
> ends with ".patch". we should make this configurable so that it can be used
> with other projects that might want to be more permissive (i.e. ".patch.txt")
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
