[
https://issues.apache.org/jira/browse/HADOOP-11984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14548393#comment-14548393
]
Haohui Mai commented on HADOOP-11984:
-------------------------------------
bq. I doubt it's any less reliable than reading the XML directly since the only
way this should break is if JUnit's XML DTD changes.... which, in turn, would
break any replacement of this code as well.
I'm unsure how the reliability / robustness argument holds. Just a quick skim
it looks like that the code snippet assumes that JUnit pretty prints the XML
results (i.e., the result of each test in a different line). Any XML parsers in
production (e.g., xml.sax in Python) should handle non-pretty-printed XML well.
bq. I'd also argue that this is likely going to be faster and might even use
less memory, given how highly optimized grep implementations tend to be... but
the awk might slow it down.
It seems to me that it is more of an apple vs orange comparison -- more
importantly, does the time parsing {{TEST-*xml}} (which takes seconds at
maximum) actually matter, give the fact that in general Jenkins spends 15 mins
to build the trunk, and ~2 hours to run the tests?
Popping up one level -- it looks like you have some concerns on moving
test-patch to other scripting languages that have more choices of libraries. I
understand you're probably have expertise in bash / awk but can you elaborate?
test-patch.sh has been a minefield for a while and we're continuously adding
new features into it.
I appreciate your contributions on these scripts. It helps get rid a lot of
headaches. I'm wondering whether there are anythings can be done to improve the
maintainability and reduce the bars of getting involved (e.g., reusing
libraries from other scripting languages) in the longer term.
> Enable parallel JUnit tests in pre-commit.
> ------------------------------------------
>
> Key: HADOOP-11984
> URL: https://issues.apache.org/jira/browse/HADOOP-11984
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Attachments: HADOOP-11984.001.patch, HADOOP-11984.002.patch,
> HADOOP-11984.003.patch, HADOOP-11984.004.patch
>
>
> HADOOP-9287 and related issues implemented the parallel-tests Maven profile
> for running JUnit tests in multiple concurrent processes. This issue
> proposes to activate that profile during pre-commit to speed up execution.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
