[
https://issues.apache.org/jira/browse/HADOOP-11933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554847#comment-14554847
]
Allen Wittenauer edited comment on HADOOP-11933 at 5/21/15 7:22 PM:
--------------------------------------------------------------------
I'm playing shell games. :D
--dockermode is a standalone option that says "hey, we were invoked underneath
docker, don't spawn another one" TESTPATCHMODE has all of the user passed
parameters. We then append --basedir, etc to *override* the values in
TESTPATCHMODE.
So this code is adding --dockermode to the parameter list. If you want, I can
move --dockermode to be after TESTPATCHMODE if it makes it cleaner. Or maybe
just a comment here, warning of the black magic in the works.
was (Author: aw):
I'm play shell games. :D
--dockermode is a standalone option that says "hey, we were invoked underneath
docker, don't spawn another one" TESTPATCHMODE has all of the user passed
parameters. We then append --basedir, etc to *override* the values in
TESTPATCHMODE.
So this code is adding --dockermode to the parameter list. If you want, I can
move --dockermode to be after TESTPATCHMODE if it makes it cleaner. Or maybe
just a comment here, warning of the black magic in the works.
> run test-patch.sh in a docker container under Jenkins
> -----------------------------------------------------
>
> Key: HADOOP-11933
> URL: https://issues.apache.org/jira/browse/HADOOP-11933
> Project: Hadoop Common
> Issue Type: Test
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Attachments: HADOOP-11933.00.patch, HADOOP-11933.01.patch,
> HADOOP-11933.02.patch, HADOOP-11933.03.patch, HADOOP-11933.04.patch,
> HADOOP-11933.05.patch
>
>
> because of how hard it is to control the content of the Jenkins environment,
> it would be beneficial to run it in a docker container so that we can have
> tight control of the environment
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
