[
https://issues.apache.org/jira/browse/HADOOP-11933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555222#comment-14555222
]
Allen Wittenauer commented on HADOOP-11933:
-------------------------------------------
bq. There is horribly little in the way of security while pulling down images.
Can we please atleast pass in the image / dockerfile as a command line option?
I was originally going to do this but decided to do it as a follow-on JIRA at a
later date. The key problem is that we need all of the test-patch-docker bits
in the same directory. We need to essentially copy the standard bits and then
the provided file to the processing dir then launch docker against that. That
requires quite a bit of testing esp with --reexec mode. It's also worth noting
that using this on the Jenkins hosts prevents the ability to actually precommit
test the test-patch-docker bits. So, it's on my to-do list but a lower
priority vs. everything else. I really wanted to get this in without this
functionality to unblock other, higher priority items.
bq. Also we are curling and wgetting http instead of https.
Good catch. I'll update the dev Dockerfile as well.
bq. Could you please also write documentation for several functions missing it?
Sure. Just be aware that they are private to the test-patch-docker script.
> run test-patch.sh in a docker container under Jenkins
> -----------------------------------------------------
>
> Key: HADOOP-11933
> URL: https://issues.apache.org/jira/browse/HADOOP-11933
> Project: Hadoop Common
> Issue Type: Test
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Attachments: HADOOP-11933.00.patch, HADOOP-11933.01.patch,
> HADOOP-11933.02.patch, HADOOP-11933.03.patch, HADOOP-11933.04.patch,
> HADOOP-11933.05.patch
>
>
> because of how hard it is to control the content of the Jenkins environment,
> it would be beneficial to run it in a docker container so that we can have
> tight control of the environment
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
