[
https://issues.apache.org/jira/browse/HADOOP-11937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14559680#comment-14559680
]
Colin Patrick McCabe edited comment on HADOOP-11937 at 5/26/15 8:17 PM:
------------------------------------------------------------------------
You're right, I am behind the times. It's nice that \-Pnative works on more
platforms now.
If there is stuff included in [~cnauroth]'s "full build" that doesn't yet work
on Mac, test-patch.sh can simply detect that we are running on a Mac and not
add those compilation flags. That way, we are not blocked here, but Mac users
still can run test-patch.sh.
was (Author: cmccabe):
You're right, I am behind the times. It's nice that \-Pnative works on more
platforms now.
If there is still included in [~cnauroth]'s "full build" that doesn't yet work
on Mac, test-patch.sh can simply detect that we are running on a Mac and not
add those compilation flags. That way, we are not blocked here, but Mac users
still can run test-patch.sh.
> Guarantee a full build of all native code during pre-commit.
> ------------------------------------------------------------
>
> Key: HADOOP-11937
> URL: https://issues.apache.org/jira/browse/HADOOP-11937
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
> Reporter: Chris Nauroth
>
> Some of the native components of the build are considered optional and either
> will not build at all without passing special flags to Maven or will allow a
> build to proceed if dependencies are missing from the build machine. If
> these components do not get built, then pre-commit isn't really providing
> full coverage of the build. This issue proposes to update test-patch.sh so
> that it does a full build of all native components.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
