[ 
https://issues.apache.org/jira/browse/HADOOP-12036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14563579#comment-14563579
 ] 

Colin Patrick McCabe commented on HADOOP-12036:
-----------------------------------------------

I like the idea of having some utility file which all our top-level 
CMakeLists.txt files can source.  Also as I commented on HADOOP-11987, we 
should get rid of the duplicate {{FindJNI.cmake}} file in the mapreduce 
directory.

However, we have libraries and programs that don't need or want to link to JNI 
(hdfs native client, libhadooppipes, etc.).  We need to make sure that we don't 
add anything to CFLAGS, CXXFLAGS, or LDFLAGS that would be disruptive to them 
or that would force them to link against {{libjvm.so}}.

Alan, why don't you post a patch that has the Solaris support and the cleanup 
you want, and we can review it here.

> Consolidate all of the cmake extensions in one directory
> --------------------------------------------------------
>
>                 Key: HADOOP-12036
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12036
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Allen Wittenauer
>            Assignee: Alan Burlison
>         Attachments: prototype01.txt
>
>
> Rather than have a half-dozen redefinitions, custom extensions, etc, we 
> should move them all to one location so that the cmake environment is 
> consistent between the various native components.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to