[
https://issues.apache.org/jira/browse/HADOOP-11929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564141#comment-14564141
]
Hadoop QA commented on HADOOP-11929:
------------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | reexec | 0m 0s | dev-support patch detected. |
| {color:red}-1{color} | javac | 0m 23s | branch /
hadoop-common-project/hadoop-common compilation is broken. |
| {color:blue}0{color} | @author | 5m 5s | Skipping @author checks as
test-patch has been patched. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 2 new or modified test files. |
| {color:red}-1{color} | javac | 0m 22s | patch /
hadoop-common-project/hadoop-common javac is broken. |
| {color:green}+1{color} | javadoc | 0m 58s | Patched
hadoop-common-project/hadoop-common appears healthy. |
| {color:green}+1{color} | javadoc | 2m 23s | Patched
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api appears healthy. |
| {color:green}+1{color} | javadoc | 0m 27s | Patched
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common appears healthy. |
| {color:green}+1{color} | javadoc | 0m 20s | Patched
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
appears healthy. |
| {color:green}+1{color} | releaseaudit | 0m 36s | Patch does not generate
release audit warnings. |
| {color:red}-1{color} | checkstyle | 2m 26s | The applied patch generated
14 new checkstyle issues (total was 1, now 15). |
| {color:red}-1{color} | checkstyle | 2m 59s | The applied patch generated 1
new checkstyle issues (total was 212, now 212). |
| {color:red}-1{color} | checkstyle | 3m 50s | The applied patch generated 1
new checkstyle issues (total was 14, now 14). |
| {color:red}-1{color} | shellcheck | 0m 8s | The applied patch generated 1
new shellcheck (v0.3.3) issues (total was 38, now 27). |
| {color:red}-1{color} | whitespace | 0m 7s | The patch has 6 line(s) that
end in whitespace. Use git apply --whitespace=fix. |
| {color:red}-1{color} | mvninstall | 0m 36s | patch /
hadoop-common-project/hadoop-common mvn install is broken. |
| {color:red}-1{color} | unit | 0m 22s | patch /
hadoop-common-project/hadoop-common unit tests are broken. |
| {color:red}-1{color} | unit | 0m 20s | patch /
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api unit tests are broken. |
| | | 81m 46s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12736018/HADOOP-11929.02.patch |
| Optional Tests | shellcheck javadoc javac unit findbugs checkstyle |
| git revision | trunk / 788bfa0 |
| javac |
/home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/branch-javac-hadoop-common-project_hadoop-common.txt
|
| javac |
/home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/patch-javac-hadoop-common-project_hadoop-common.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6864/artifact/patchprocess/diffcheckstylehadoop-common.txt
https://builds.apache.org/job/PreCommit-HADOOP-Build/6864/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt
https://builds.apache.org/job/PreCommit-HADOOP-Build/6864/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt
|
| shellcheck |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6864/artifact/patchprocess/diffpatchshellcheck.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6864/artifact/patchprocess/whitespace.txt
|
| mvninstall |
/home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt
|
| unit |
/home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
|
| unit |
/home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6864/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6864/console |
This message was automatically generated.
> add test-patch plugin points for customizing build layout
> ---------------------------------------------------------
>
> Key: HADOOP-11929
> URL: https://issues.apache.org/jira/browse/HADOOP-11929
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Sean Busbey
> Assignee: Allen Wittenauer
> Priority: Minor
> Attachments: HADOOP-11929.00.patch, HADOOP-11929.01.patch,
> HADOOP-11929.02.patch, HADOOP-11929.03.patch, hadoop.sh
>
>
> Sean Busbey and I had a chat about this at the Bug Bash. Here's the proposal:
> * Introduce the concept of a 'personality module'.
> * There can be only one personality.
> * Personalities provide a single function that takes as input the name of
> the test current being processed
> * This function uses two other built-in functions to define two queues:
> maven module name and profiles to use against those maven module names
> * If something needs to be compiled prior to this test (but not actually
> tested), the personality will be responsible for doing that compilation
> In hadoop, the classic example is hadoop-hdfs needs common compiled with the
> native bits. So prior to the javac tests, the personality would check
> CHANGED_MODULES, see hadoop-hdfs, and compile common w/ -Pnative prior to
> letting test-patch.sh do the work in hadoop-hdfs. Another example is our lack
> of test coverage of various native bits. Since these require profiles to be
> defined prior to compilation, the personality could see that something
> touches native code, set the appropriate profile, and let test-patch.sh be on
> its way.
> One way to think of it is some higher order logic on top of the automated
> 'figure out what modules and what tests to run' functions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
