[ 
https://issues.apache.org/jira/browse/HADOOP-7139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578620#comment-14578620
 ] 

Vinayakumar B commented on HADOOP-7139:
---------------------------------------

[~kanaka], Just noticed, some nits in Test to be corrected before commit.

1. {code}Path file = new Path(System.getProperty("test.build.data", ".")
       + "/testseqappend.seq");{code}
Use "build/test/data" as default value for the system property, as all temp 
files under 'build' will be cleared by 'mvn clean', but not in '.'

2. {{fs.close();}} at the end of test is not required. Since the {{tearDown()}} 
is having {{AfterClass}} annotation, if some other tests added, then they will 
also get the same {{fs}}.

> Allow appending to existing SequenceFiles
> -----------------------------------------
>
>                 Key: HADOOP-7139
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7139
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: io
>    Affects Versions: 1.0.0
>            Reporter: Stephen Rose
>            Assignee: kanaka kumar avvaru
>            Priority: Minor
>              Labels: BB2015-05-TBR
>         Attachments: HADOOP-7139-01.patch, HADOOP-7139-02.patch, 
> HADOOP-7139-kt.patch, HADOOP-7139.patch, HADOOP-7139.patch, 
> HADOOP-7139.patch, HADOOP-7139.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to