[ 
https://issues.apache.org/jira/browse/HADOOP-7817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578647#comment-14578647
 ] 

Vinayakumar B commented on HADOOP-7817:
---------------------------------------

Thanks for updating the patch [~kanaka]. 
Source changes looks good.

Have some nits in test.
1. {{fs}} is not closed after test.
2. {{in}} also not closed.
3. Use default value 'build/test/data' for 
{{System.getProperty("test.build.data", ".")}}

> RawLocalFileSystem.append() should give FSDataOutputStream with accurate 
> .getPos()
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-7817
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7817
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 1.0.0
>            Reporter: Kristofer Tomasette
>            Assignee: kanaka kumar avvaru
>            Priority: Minor
>         Attachments: HADOOP-7817-01.patch, HADOOP-7817.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> When RawLocalFileSyste.append() is called it returns an FSDataOutputStream 
> whose .getPos() returns 0.
> getPos() should return position in the file where appends will start writing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to