[ 
https://issues.apache.org/jira/browse/HADOOP-12076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14579988#comment-14579988
 ] 

Sean Busbey commented on HADOOP-12076:
--------------------------------------

General comments

* Are we worried about how the cache gets aged off?
* Since AbstractJavaKeyStore isn't thread safe, do we know what happens if 
multiple instances are pointing at the same jks file?
* Presuming the above works, how do we reconcile changes that happen to the 
underlying jks against the cache?

{code}
+
+    // delete the actual keystore
+    file.delete();
+    // make sure the password is cached
+    assertArrayEquals(passwd, 
provider.getCredentialEntry("pass").getCredential());
+  }
{code}

You should do something to ensure that deleting the file means that non-cached 
entries won't be returned.

> Incomplete Cache Mechanism in CredentialProvider API
> ----------------------------------------------------
>
>                 Key: HADOOP-12076
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12076
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>            Reporter: Larry McCay
>            Assignee: Larry McCay
>         Attachments: HADOOP-12076-001.patch
>
>
> The AbstractJavaKeyStoreProvider class in the CredentialProvider API has a 
> cache member variable and interrogation of it during access but does not 
> populate it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to