[
https://issues.apache.org/jira/browse/HADOOP-11965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14587528#comment-14587528
]
Yongjun Zhang commented on HADOOP-11965:
----------------------------------------
HI [~yufeigu],
Thanks for the patch. It looks good, only a few nits/suggestions:
* change DEFAULT_TOP_LINE_NUM to DEFAULT_TOP_NUM_FAILED_TESTS (imagine we may
report multiple lines for one test in the future)
* change num_line to num_failed_tests
* change error_num to error_count (not to confuse with errno)
* About "Among x runs examined, top y failed tests ...". The y here need to
consider the case that when y is bigger than total number of failed tests.
Suggest to change to "Among x runs examined, y tests failed, and the top z
failed tests are (<#failedRuns: testName>):", where y is the total number of
failed tests, and make the z here MIN(z, y).
* In non-summary mode, modify the report to "Among x runs examined, all y
failed tests are (<#failedRuns: testName>):
*
{code}
logging.info("\n" + str(error_num) + " errors found, check error details with
non summary mode."
{code}
Change to
{code}
logging.info("\n" + str(error_num) + " errors found, you may re-run in non
summary mode to see error details."
{code}
Thanks.
> determine-flaky-tests needs a summary mode
> ------------------------------------------
>
> Key: HADOOP-11965
> URL: https://issues.apache.org/jira/browse/HADOOP-11965
> Project: Hadoop Common
> Issue Type: Test
> Reporter: Allen Wittenauer
> Assignee: Yufei Gu
> Priority: Minor
> Attachments: HADOOP-11965.001.patch
>
>
> Running determine-flaky-tests against PreCommit-HDFS-Build generates just
> slightly under 10,000 lines of output. That's significantly too much to be
> useful for the casual user. It's also not formatted in such a way to be
> easily machine parseable to generate a decent report. A summary mode should
> be added that just prints out the top X failed tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
