[ 
https://issues.apache.org/jira/browse/HADOOP-12045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14594665#comment-14594665
 ] 

Kazuho Fujii commented on HADOOP-12045:
---------------------------------------

Hi [~cnauroth]. Thank you for the comment.

bq. 1. Nitpick: In testSetTimesSymlinkToDir, please use "dir" instead of "file" 
for the sub-directory name.

I fixed it. Thanks for pointing it out.

bq. 2. I think we also can update TestCopyPreserveFlag as part of this patch. 
Currently, it only checks mtime, but now it can check atime too.

I updated it. I refactored the code at the same time. Is this acceptable? The 
just refactored version is included in HADOOP-12045.005-1.patch.

> Enable LocalFileSystem#setTimes to change atime
> -----------------------------------------------
>
>                 Key: HADOOP-12045
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12045
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>            Reporter: Kazuho Fujii
>            Assignee: Kazuho Fujii
>            Priority: Minor
>         Attachments: HADOOP-12045.001.patch, HADOOP-12045.002.patch, 
> HADOOP-12045.003.patch, HADOOP-12045.004-1.patch, HADOOP-12045.004-2.patch, 
> HADOOP-12045.005-1.patch, HADOOP-12045.005-2.patch
>
>
> LocalFileSystem#setTimes method can not change the last access time currently.
> With java.nio.file package in Java 7, we can implement the function easily.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to