[
https://issues.apache.org/jira/browse/HADOOP-12036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599781#comment-14599781
]
Colin Patrick McCabe commented on HADOOP-12036:
-----------------------------------------------
bq. I've been as conservative as I can with the existing Linux code as I'm wary
of breaking distros other than the one I'm using (Centos), so I thing doing it
as a follow-up might be prudent.
Sure.
bq. And yes, much better as you say to add a "XXX Add new compiler support
here" comment, I'll make that change.
So, patch 003 has this:
{code}
130 # Add in support other compilers here, if necessary.
131 if(NOT (CMAKE_COMPILER_IS_GNUCC AND CMAKE_COMPILER_IS_GNUCXX))
132
133 # Assume GCC and set the shared compiler flags.
134 else()
135 hadoop_add_compiler_flags("${GCC_SHARED_FLAGS}")
136 endif()
{code}
So it still won't work for clang. Since clang works right now, this would
cause a regression.
Can we just get rid of the if statement completely and add a TODO for other
compilers? +1 pending that.
> Consolidate all of the cmake extensions in one directory
> --------------------------------------------------------
>
> Key: HADOOP-12036
> URL: https://issues.apache.org/jira/browse/HADOOP-12036
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Allen Wittenauer
> Assignee: Alan Burlison
> Attachments: HADOOP-12036.001.patch, HADOOP-12036.002.patch,
> HADOOP-12036.003.patch
>
>
> Rather than have a half-dozen redefinitions, custom extensions, etc, we
> should move them all to one location so that the cmake environment is
> consistent between the various native components.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
