[
https://issues.apache.org/jira/browse/HADOOP-12138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14607494#comment-14607494
]
Kengo Seki commented on HADOOP-12138:
-------------------------------------
As for hadoop-hdfs-project/hadoop-hdfs/src/main/shellprofile.d/hdfs.sh, yetus
correctly determines it as shell by default:
{code}
[sekikn@localhost hadoop]$ dev-support/test-patch.sh --debug --project=hadoop
/tmp/HDFS-7991-shellpart.patch
(snip)
[Tue Jun 30 04:42:01 UTC 2015 DEBUG]: Using builtin mvn personality_file_tests
[Tue Jun 30 04:42:01 UTC 2015 DEBUG]: tests/shell:
hadoop-hdfs-project/hadoop-hdfs/src/main/shellprofile.d/hdfs.sh
[Tue Jun 30 04:42:01 UTC 2015 DEBUG]: Testing against shellcheck
(snip)
{code}
Because its name ends with .sh:
{code}
function builtin_mvn_personality_file_tests
{
(snip)
if [[ ${filename} =~ src/main/webapp ]]; then
yetus_debug "tests/webapp: ${filename}"
elif [[ ${filename} =~ \.sh
|| ${filename} =~ \.cmd
]]; then
yetus_debug "tests/shell: ${filename}"
(snip)
elif [[ ${filename} =~ pom.xml$
|| ${filename} =~ \.java$
|| ${filename} =~ \.scala$
|| ${filename} =~ src/main
]]; then
if [[ ${filename} =~ src/main/bin
|| ${filename} =~ src/main/sbin ]]; then
yetus_debug "tests/shell: ${filename}"
else
yetus_debug "tests/javadoc+units: ${filename}"
(snip)
{code}
Should we define the hadoop specific personality_file_tests?
> hadoop personality needs to know about shellprofile.d
> -----------------------------------------------------
>
> Key: HADOOP-12138
> URL: https://issues.apache.org/jira/browse/HADOOP-12138
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: yetus
> Affects Versions: HADOOP-12111
> Reporter: Allen Wittenauer
> Assignee: Kengo Seki
>
> Now that test-patch.sh allows projects to override the test determination
> code, hadoop's personality needs to have some logic for shellprofile.d added
> to fix the issue noticed in HADOOP-12023.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
