[
https://issues.apache.org/jira/browse/HADOOP-11042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14607583#comment-14607583
]
Hadoop QA commented on HADOOP-11042:
------------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 20m 9s | Pre-patch trunk has 1 extant
Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 17 new or modified test files. |
| {color:red}-1{color} | javac | 0m 58s | The patch appears to cause the
build to fail. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12665868/HADOOP-11042.001.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / d3797f9 |
| Pre-patch Findbugs warnings |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7099/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
|
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7099/console |
This message was automatically generated.
> CryptoInputStream throwing wrong exception class on errors
> ----------------------------------------------------------
>
> Key: HADOOP-11042
> URL: https://issues.apache.org/jira/browse/HADOOP-11042
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Steve Loughran
> Assignee: Yi Liu
> Labels: BB2015-05-TBR
> Attachments: HADOOP-11042.001.patch
>
>
> Having had a quick look at the {{CryptoInputStream}} class, it's not in sync
> with all the other filesystem's exception logic, as specified in
> {{src/site/markdown/filesystem/fsdatainputstream.md}}
> Operations MUST throw an {{IOException}} on out of bounds reads, ideally
> {{EOFException}} :
> # {{read(byte[] b, int off, int len)}}
> # {{seek(long pos) }}
> # {{seekToNewSource}}
> The tests you want to extend to verify expected behaviour are in
> {{AbstractContractOpenTest}} and {{AbstractContractSeekTest}}
> also, the {{HasEnhancedByteBufferAccess}} implementations may want to think
> about using {{checkStream()}} before acting on a potentially closed stream.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
