[
https://issues.apache.org/jira/browse/HADOOP-11914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-11914:
--------------------------------
Attachment: HADOOP-11914.HADOOP-12111.04.patch
Attaching a fixed and simplified patch.
Test data which covers update, delete, create, chmod:
{code}
[sekikn@mobile hadoop]$ cat /tmp/test.patch
diff --git a/BUILDING.txt b/BUILDING.txt
index 2aeade4..56f34ce 100644
--- a/BUILDING.txt
+++ b/BUILDING.txt
@@ -282,7 +282,7 @@ Requirements:
* Internet connection for first build (to fetch all Maven and Hadoop
dependencies)
* Unix command-line tools from GnuWin32: sh, mkdir, rm, cp, tar, gzip. These
tools must be present on your PATH.
-* Python ( for generation of docs using 'mvn site')
+* Python (for generation of docs using 'mvn site')
Unix command-line tools are also included with the Windows Git package which
can be downloaded from http://git-scm.com/download/win.
diff --git a/NOTICE.txt b/NOTICE.txt
deleted file mode 100644
index 62fc581..0000000
--- a/NOTICE.txt
+++ /dev/null
@@ -1,2 +0,0 @@
-This product includes software developed by The Apache Software
-Foundation (http://www.apache.org/).
diff --git a/foo b/foo
new file mode 100644
index 0000000..e69de29
diff --git a/start-build-env.sh b/start-build-env.sh
old mode 100755
new mode 100644
{code}
Test result. Four types of change above are all successfully detected.
{code}
[sekikn@mobile hadoop]$ dev-support/test-patch.sh
--basedir=/Users/sekikn/hadoop --debug --project=hadoop /tmp/test.patch
(snip)
[Tue Jun 30 22:44:24 JST 2015 DEBUG]: Determining needed tests for BUILDING.txt
[Tue Jun 30 22:44:24 JST 2015 DEBUG]: Using builtin mvn personality_file_tests
[Tue Jun 30 22:44:24 JST 2015 DEBUG]: Determining needed tests for NOTICE.txt
[Tue Jun 30 22:44:24 JST 2015 DEBUG]: Using builtin mvn personality_file_tests
[Tue Jun 30 22:44:24 JST 2015 DEBUG]: Determining needed tests for foo
[Tue Jun 30 22:44:24 JST 2015 DEBUG]: Using builtin mvn personality_file_tests
[Tue Jun 30 22:44:24 JST 2015 DEBUG]: Testing against shellcheck
[Tue Jun 30 22:44:24 JST 2015 DEBUG]: Adding shellcheck
[Tue Jun 30 22:44:24 JST 2015 DEBUG]: Determining needed tests for
start-build-env.sh
[Tue Jun 30 22:44:24 JST 2015 DEBUG]: Using builtin mvn personality_file_tests
[Tue Jun 30 22:44:24 JST 2015 DEBUG]: tests/shell: start-build-env.sh
[Tue Jun 30 22:44:24 JST 2015 DEBUG]: Testing against shellcheck
(snip)
{code}
> test-patch.sh confused by certain patch formats
> -----------------------------------------------
>
> Key: HADOOP-11914
> URL: https://issues.apache.org/jira/browse/HADOOP-11914
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: yetus
> Affects Versions: HADOOP-12111
> Reporter: Allen Wittenauer
> Assignee: Kengo Seki
> Priority: Critical
> Attachments: HADOOP-11914.001.patch, HADOOP-11914.002.patch,
> HADOOP-11914.HADOOP-12111.03.patch, HADOOP-11914.HADOOP-12111.04.patch
>
>
> A simple patch example:
> {code}
> diff --git a/start-build-env.sh b/start-build-env.sh
> old mode 100644
> new mode 100755
> {code}
> start-build-env.sh will not show up in the changed files list and therefore
> will not get run by shellcheck.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
