[ 
https://issues.apache.org/jira/browse/HADOOP-12048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609124#comment-14609124
 ] 

Sangjin Lee commented on HADOOP-12048:
--------------------------------------

[~gliptak], the compilation failure is definitely caused by the patch, and I am 
able to reproduce it. It is because jetty-util was removed from the (test) 
dependencies in hadoop-auth.

As a rule, we need to be real careful in *removing* dependencies. There are 
many necessary runtime dependencies that cannot be verified by the maven 
dependency plugin. One cannot remove them unless we're 100% certain that 
runtime dependency is not needed.

The easier problem to solve (but probably of lesser value) is to add direct but 
undeclared dependencies. Those are easily detected by the maven dependency 
plugin.

> many undeclared used dependencies (and declared unused dependencies)
> --------------------------------------------------------------------
>
>                 Key: HADOOP-12048
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12048
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.0.0
>            Reporter: Sangjin Lee
>            Assignee: Gabor Liptak
>         Attachments: HADOOP-12048.1.patch, HADOOP-12048.2.patch, 
> HADOOP-12048.3.patch, dependency-analysis.txt, hadoop-unused.txt
>
>
> Currently there are numerous undeclared used dependencies and declared unused 
> dependencies in the hadoop projects.
> Undeclared used dependencies are easier errors to correct, and correcting 
> them will lead to a better management of dependencies (enabling stricter 
> dependency frameworks down the road).
> Declared unused dependencies are harder to resolve, as many may be legitimate 
> runtime dependencies. But fixing them would lead to smaller profiles for 
> hadoop projects.
> We can do a one-time scan of dependency issues and fix them. However, in the 
> long run, it would be nice to be able to enforce those rules via maven 
> plug-in.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to