[
https://issues.apache.org/jira/browse/HADOOP-11903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615638#comment-14615638
]
Allen Wittenauer commented on HADOOP-11903:
-------------------------------------------
bq. If people really strongly feel that these kind of class names have been
abused in the past
I can probably count on one hand the number of times Default has been used in a
sane way in hadoop. I'll need toes to count the number of times it has been
used incorrectly.
bq. maybe it would be more productive to have a discussion on the mailing list
about how we should improve our code review process
yes, that sounds like a good thing for Hadoop to do. In the meantime, for
yetus, we'll continue down this path to offer this as optional functionality.
> test-patch should fail any new classes called Default-foo
> ---------------------------------------------------------
>
> Key: HADOOP-11903
> URL: https://issues.apache.org/jira/browse/HADOOP-11903
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: yetus
> Affects Versions: HADOOP-12111
> Reporter: Allen Wittenauer
> Assignee: Kengo Seki
> Attachments: HADOOP-11903.HADOOP-12111.00.patch
>
>
> In the past, we've named things like DefaultResourceCalculator,
> DefaultContainerExecutor, and DefaultCodec that do nothing but cause problems
> down the road since they are effectively version and functionality locked
> forever. If these examples had been named what they truly were (e.g.,
> MemoryResourceCalculator, SimpleContainerExecutor, and GZipCodec), the
> defaults could then be changed in the future in a compatible way.
> One way to enforce this is to prevent the creation of new classes called
> Default-anything.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
