[
https://issues.apache.org/jira/browse/HADOOP-11903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616073#comment-14616073
]
Allen Wittenauer edited comment on HADOOP-11903 at 7/7/15 2:36 AM:
-------------------------------------------------------------------
But .gitignore isn't read by e.g., maven. So it's very easy to generate a patch
that has a forbidden file in it that actually passes the rest of the test
suite. Then on apply+commit, bombs the build.
Of course, let's not forget that not all projects are on git.
was (Author: aw):
But .gitignore isn't read by e.g., maven. So it's very easy to generate a patch
that has a forbidden file in it that actually passes the rest of the test
suite. Then on apply+commit, bombs the build.
> test-patch should fail any new classes called Default-foo
> ---------------------------------------------------------
>
> Key: HADOOP-11903
> URL: https://issues.apache.org/jira/browse/HADOOP-11903
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: yetus
> Affects Versions: HADOOP-12111
> Reporter: Allen Wittenauer
> Assignee: Kengo Seki
> Attachments: HADOOP-11903.HADOOP-12111.00.patch
>
>
> In the past, we've named things like DefaultResourceCalculator,
> DefaultContainerExecutor, and DefaultCodec that do nothing but cause problems
> down the road since they are effectively version and functionality locked
> forever. If these examples had been named what they truly were (e.g.,
> MemoryResourceCalculator, SimpleContainerExecutor, and GZipCodec), the
> defaults could then be changed in the future in a compatible way.
> One way to enforce this is to prevent the creation of new classes called
> Default-anything.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
