[ 
https://issues.apache.org/jira/browse/HADOOP-11854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617195#comment-14617195
 ] 

Chris Douglas commented on HADOOP-11854:
----------------------------------------

* The changes to {{TestCompositeService.java}} incorrectly change coments 
naming a state ({{INITED}}) to "initialized" (same may apply to {{MRAppMaster}}
* Could correcting the spelling error in {{JobHistoryEventHandler}} break tools 
searching for the misspelled string? Didn't look at the context

These are pretty funny:
{noformat}
- * Unless required by joblicable law or agreed to in writing, software
+ * Unless required by applicable law or agreed to in writing, software
{noformat}

In the future, please try to break this up into smaller patches, 
per-subproject. Will run an updated version through Jenkins to re-test

> Fix Typos in all the projects
> -----------------------------
>
>                 Key: HADOOP-11854
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11854
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Brahma Reddy Battula
>            Priority: Minor
>              Labels: BB2015-05-TBR
>         Attachments: HADOOP-11854.suggestions.001.patch, 
> HADOOP-11854.suggestions.002.patch
>
>
> Recently I had seen, there are so many jira's for fixing the typo's ( Keep on 
> accumulating more ). Hence I want to plan in proper manner such that 
> everything will be addressed..
> I am thinking, we can fix project level ( at most package level)...
> My intention to avoid the number of jira's on typo's...One more suggestion to 
> reviewer's is please dn't commit for class level try to check project level ( 
> atmost package level) if any such typo's present...
> Please correct me If I am wrong.. I will close this jira..



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to