[
https://issues.apache.org/jira/browse/HADOOP-11903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-11903:
--------------------------------
Attachment: HADOOP-11903.HADOOP-12111.02.patch
-02:
Changed the plugin name to 'filepath.sh' and made it more generic. Now it can:
* target any file types, not only java sources
* check the entire file path, not only file name
Other modifications:
* Safety check for the empty case is not implemented, because there might be a
project which has no filename convention. Instead, it shows a message to
console if ${FILEPATH_RULE} is not provided.
* Checking for DefaultSomething is moved to the hadoop personality.
* The help message is enhanced, because the notation of this option become a
bit complicated. Please correct if the message is grammatically wrong.
> test-patch plugin for checking file name conventions
> ----------------------------------------------------
>
> Key: HADOOP-11903
> URL: https://issues.apache.org/jira/browse/HADOOP-11903
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: yetus
> Affects Versions: HADOOP-12111
> Reporter: Allen Wittenauer
> Assignee: Kengo Seki
> Attachments: HADOOP-11903.HADOOP-12111.00.patch,
> HADOOP-11903.HADOOP-12111.01.patch, HADOOP-11903.HADOOP-12111.02.patch
>
>
> Providing yetus with the functionality to detect newly added files which
> doesn't follow the naming conventions. As for java, it also can be used for
> checking classnames. In the past, we've named things like
> DefaultResourceCalculator, DefaultContainerExecutor, and DefaultCodec that do
> nothing but cause problems down the road since they are effectively version
> and functionality locked forever. If these examples had been named what they
> truly were (e.g., MemoryResourceCalculator, SimpleContainerExecutor, and
> GZipCodec), the defaults could then be changed in the future in a compatible
> way. One way to enforce this is to prevent the creation of new classes called
> Default-anything.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
