[
https://issues.apache.org/jira/browse/HADOOP-12211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622534#comment-14622534
]
Chris Douglas commented on HADOOP-12211:
----------------------------------------
The patch fails its own unit test.
* It's missing a call to {{readProcDiskInfoFile}} with {{getStorageBytesRead}}
and {{getStorageBytesWritten}}
* The {{assertEquals}} parameters are backwards. They should be
{{assertEquals(expectedValue, actualValue)}}
* The {{perDiskSectorSize}} member field is never assigned a non-null value
Please fix (and test) the patch.
> Collect disks usages on the node
> --------------------------------
>
> Key: HADOOP-12211
> URL: https://issues.apache.org/jira/browse/HADOOP-12211
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Robert Grandl
> Assignee: Robert Grandl
> Labels: yarn-common, yarn-util
> Attachments: HADOOP-12211-1.patch, YARN-3820-1.patch,
> YARN-3820-2.patch, YARN-3820-3.patch, YARN-3820-4.patch
>
>
> In this JIRA we propose to collect disks usages on a node. This JIRA is part
> of a larger effort of monitoring resource usages on the nodes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
