[
https://issues.apache.org/jira/browse/HADOOP-11903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14623023#comment-14623023
]
Andrew Wang commented on HADOOP-11903:
--------------------------------------
Just a few more small things from me:
* I'd still prefer to not have the "Default*.java" pattern even in the hadoop
profile. It's better to do classname checking in checkstyle as we discussed
above, particularly because filename checking won't catch nested classes.
* The example in the help should also reference a different usecase besides
classname checking, say what Flink does with their lib folder.
Otherwise +1 from me besides Allen's comments, thanks for working on this
[~sekikn].
> test-patch plugin for checking file name conventions
> ----------------------------------------------------
>
> Key: HADOOP-11903
> URL: https://issues.apache.org/jira/browse/HADOOP-11903
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: yetus
> Affects Versions: HADOOP-12111
> Reporter: Allen Wittenauer
> Assignee: Kengo Seki
> Attachments: HADOOP-11903.HADOOP-12111.00.patch,
> HADOOP-11903.HADOOP-12111.01.patch, HADOOP-11903.HADOOP-12111.02.patch
>
>
> Providing yetus with the functionality to detect newly added files which
> doesn't follow the naming conventions. As for java, it also can be used for
> checking classnames. In the past, we've named things like
> DefaultResourceCalculator, DefaultContainerExecutor, and DefaultCodec that do
> nothing but cause problems down the road since they are effectively version
> and functionality locked forever. If these examples had been named what they
> truly were (e.g., MemoryResourceCalculator, SimpleContainerExecutor, and
> GZipCodec), the defaults could then be changed in the future in a compatible
> way. One way to enforce this is to prevent the creation of new classes called
> Default-anything.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
