[ 
https://issues.apache.org/jira/browse/HADOOP-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14624950#comment-14624950
 ] 

Allen Wittenauer commented on HADOOP-12130:
-------------------------------------------

bq. The "either" looks superfluous, I think?

Yes.  I was in the process of checking to see if there was another way we 
exposed maven/ant args and never got back to it. lol  (The answer is no, btw.  
Should probably JIRA that.)

bq. consider "HINT: We recommend you make the ..."

I come from the 'school of writing' where 'you' is bad form so always try to 
avoid it as best I can.   But yeah, this would probably be better.  Actually, 
just changing this to 'recommended' fixes it too.

bq. this is probably a topic for later, but what if we're running a C/C++ 
project in Maven? would that just always have BUILD_NATIVE? Should this say 
something like "has requested non-Java code" or is it specifically looking for 
JNI bindings?

You're correct that BUILD_NATIVE isn't just JNI, given it also builds non-JNI 
libraries in Hadoop. I spent quite a bit of time puzzling over what to write 
here.   I think non-Java code covers to much (e.g., scala and clojure).  I'll 
change it to "non-JVM-based".

bq. Is "javac" considered a test? if not, what version gets used to build the 
classes? to do the install step?

Yes, javac is considered a test.  install is done with JAVA_HOME so that the 
repo has the default Java bytecodes.

> document features added in 12113
> --------------------------------
>
>                 Key: HADOOP-12130
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12130
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: yetus
>    Affects Versions: HADOOP-12111
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>         Attachments: HADOOP-12130.HADOOP-12111.00.patch
>
>
> We need to write up more documentation, especially around the new stuff added 
> in 12113, since a lot of people are looking for information on those bits.  
> (e.g., "How do I use multiJDK mode?")



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to