[
https://issues.apache.org/jira/browse/HADOOP-12178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14633390#comment-14633390
]
Steve Loughran commented on HADOOP-12178:
-----------------------------------------
I don't think we need to catch {{Exception}}; IOE should be all that is caught
# it's only IOEs indicating SASL setup problems which *maybe* can be recovered
from
# That's what is on the signature too. RTEs are the ones that come up despite
the signature.
# Even with IOEs, there's a lot of possible causes that can't be retried; we'll
let those surface later.
I realise that leaving as Exception appears the lower risk, but as RTEs are
caught and rethrown, and with {{RTE, IOE}} being the sole exceptions that I can
see the codepath handling, I think we should be explicit that it is only IOEs
that are caught and re-attempted
> NPE during handling of SASL setup if problem with SASL resolver class
> ---------------------------------------------------------------------
>
> Key: HADOOP-12178
> URL: https://issues.apache.org/jira/browse/HADOOP-12178
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Affects Versions: 2.7.1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Attachments: HADOOP-12178-001.patch
>
>
> If there's any problem in the constructor of {{SaslRpcClient}}, then IPC
> Client throws an NPE rather than forwarding the stack trace. This is because
> the exception handler assumes that {{saslRpcClient}} is not null, that the
> exception is related to the SASL setup itself.
> The exception handler needs to check for {{saslRpcClient}} being null, and if
> so, rethrow the exception
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
