[
https://issues.apache.org/jira/browse/HADOOP-12207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14633886#comment-14633886
]
Kengo Seki commented on HADOOP-12207:
-------------------------------------
The case no additional error exists:
{code}
[sekikn@mobile hadoop]$ cat /tmp/test.patch
diff --git a/dev-support/releasedocmaker.py b/dev-support/releasedocmaker.py
index d2e5dda..676d37c 100755
--- a/dev-support/releasedocmaker.py
+++ b/dev-support/releasedocmaker.py
@@ -576,5 +576,7 @@ def main():
if haderrors is True:
sys.exit(1)
+
if __name__ == "__main__":
main()
+
[sekikn@mobile hadoop]$ dev-support/test-patch.sh --basedir=../dev/hadoop
--project=hadoop /tmp/test.patch
(snip)
| Vote | Subsystem | Runtime | Comment
============================================================================
| +1 | @author | 0m 00s | The patch does not contain any @author
| | | | tags.
| +1 | asflicense | 0m 26s | Patch does not generate ASF License
| | | | warnings.
| +1 | pylint | 0m 04s | There were no new pylint issues.
| +1 | whitespace | 0m 01s | Patch has no whitespace issues.
| | | 0m 32s |
|| Subsystem || Report/Notes ||
============================================================================
| git revision | HADOOP-12111 / b41fe31 |
| Optional Tests | asflicense pylint |
| uname | Darwin mobile.local 14.4.0 Darwin Kernel Version 14.4.0: Thu May 28
11:35:04 PDT 2015; root:xnu-2782.30.5~1/RELEASE_X86_64 x86_64 |
| Build tool | maven |
| Personality | /Users/sekikn/hadoop/dev-support/personality/hadoop.sh |
| Default Java | 1.7.0_80 |
| pylint | v1.4.4 |
| Max memory used | 46MB |
{code}
and the case it does:
{code}
[sekikn@mobile hadoop]$ cat /tmp/test.patch
diff --git a/dev-support/releasedocmaker.py b/dev-support/releasedocmaker.py
index d2e5dda..0a242f5 100755
--- a/dev-support/releasedocmaker.py
+++ b/dev-support/releasedocmaker.py
@@ -577,4 +577,4 @@ def main():
sys.exit(1)
if __name__ == "__main__":
- main()
+ main( )
diff --git a/dev-support/shelldocs.py b/dev-support/shelldocs.py
index fc7601a..f53c844 100755
--- a/dev-support/shelldocs.py
+++ b/dev-support/shelldocs.py
@@ -267,5 +267,5 @@ def main():
outfile.close()
if __name__ == "__main__":
- main()
+ main( )
[sekikn@mobile hadoop]$ dev-support/test-patch.sh --basedir=../dev/hadoop
--project=hadoop /tmp/test.patch
(snip)
| Vote | Subsystem | Runtime | Comment
============================================================================
| +1 | @author | 0m 00s | The patch does not contain any @author
| | | | tags.
| +1 | asflicense | 0m 24s | Patch does not generate ASF License
| | | | warnings.
| -1 | pylint | 0m 06s | The applied patch generated 4 new pylint
| | | | (v1.4.4) issues (total was 456, now 460).
| +1 | whitespace | 0m 00s | Patch has no whitespace issues.
| | | 0m 31s |
|| Subsystem || Report/Notes ||
============================================================================
| git revision | HADOOP-12111 / b41fe31 |
| Optional Tests | asflicense pylint |
| uname | Darwin mobile.local 14.4.0 Darwin Kernel Version 14.4.0: Thu May 28
11:35:04 PDT 2015; root:xnu-2782.30.5~1/RELEASE_X86_64 x86_64 |
| Build tool | maven |
| Personality | /Users/sekikn/hadoop/dev-support/personality/hadoop.sh |
| Default Java | 1.7.0_80 |
| pylint | v1.4.4 |
| pylint | /private/tmp/test-patch-hadoop/61635/diffpatchpylint.txt |
| Max memory used | 44MB |
============================================================================
============================================================================
Finished build.
============================================================================
============================================================================
[sekikn@mobile hadoop]$ cat
/private/tmp/test-patch-hadoop/61635/diffpatchpylint.txt
dev-support/releasedocmaker.py:580: [C0326(bad-whitespace), ] No space allowed
after bracket
main( )
^
dev-support/releasedocmaker.py:580: [C0326(bad-whitespace), ] No space allowed
before bracket
main( )
^
dev-support/shelldocs.py:270: [C0326(bad-whitespace), ] No space allowed after
bracket
main( )
^
dev-support/shelldocs.py:270: [C0326(bad-whitespace), ] No space allowed before
bracket
main( )
^
{code}
> Add support for pylint
> ----------------------
>
> Key: HADOOP-12207
> URL: https://issues.apache.org/jira/browse/HADOOP-12207
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: yetus
> Reporter: Allen Wittenauer
> Assignee: Kengo Seki
> Attachments: HADOOP-12207.HADOOP-12111.00.patch,
> HADOOP-12207.HADOOP-12111.01.patch
>
>
> In order to make it more obvious why I shouldn't be writing python code, we
> should add a plugin for pylint similar to what we have for shellcheck.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
