[
https://issues.apache.org/jira/browse/HADOOP-12268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14642256#comment-14642256
]
Akira AJISAKA commented on HADOOP-12268:
----------------------------------------
Nice catch, [~zxu]! The fix looks good to me. Two comments:
1. Would you remove unused imports in TestHDFSContractAppend and
AbstractContractAppendTest?
2. Would you please fix the following javadoc comment?
{code}
/**
* Test concat -if supported
*/
public abstract class AbstractContractAppendTest extends
AbstractFSContractTestBase {
{code}
"concat" should be "append".
> AbstractContractAppendTest#testRenameFileBeingAppended misses rename
> operation.
> -------------------------------------------------------------------------------
>
> Key: HADOOP-12268
> URL: https://issues.apache.org/jira/browse/HADOOP-12268
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Affects Versions: 2.5.0
> Reporter: zhihai xu
> Assignee: zhihai xu
> Attachments: HADOOP-12268.000.patch
>
>
> AbstractContractAppendTest#testRenameFileBeingAppended misses rename
> operation. Also TestHDFSContractAppend can pass the original test after fix
> the issue at {{AbstractContractAppendTest#testRenameFileBeingAppended}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
