[
https://issues.apache.org/jira/browse/HADOOP-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12254:
--------------------------------
Attachment: HADOOP-12254.HADOOP-12111.00.patch
Attaching a patch. It makes test-patch to run findbugs against
findbugs-exclude.xml.
But for some reason, test-patch results in failure even though all sub-tests
succeed.
[~aw] do you have any ideas? Entire debug output is as follows:
{code}
[sekikn@mobile hadoop]$ cat /tmp/test.patch
diff --git a/hadoop-mapreduce-project/dev-support/findbugs-exclude.xml
b/hadoop-mapreduce-project/dev-support/findbugs-exclude.xml
index f1ef2b8..2082935 100644
--- a/hadoop-mapreduce-project/dev-support/findbugs-exclude.xml
+++ b/hadoop-mapreduce-project/dev-support/findbugs-exclude.xml
@@ -531,5 +531,4 @@
<Class name="org.apache.hadoop.mapreduce.v2.hs.CachedHistoryStorage$1" />
<Bug pattern="SE_BAD_FIELD_INNER_CLASS" />
</Match>
-
</FindBugsFilter>
[sekikn@mobile hadoop]$ dev-support/test-patch.sh --basedir=../dev/hadoop
--debug --project=hadoop /tmp/test.patch
============================================================================
============================================================================
Bootstrapping test harness
============================================================================
============================================================================
[Tue Jul 28 01:54:41 JST 2015 DEBUG]: Start clock
/tmp/test-patch-hadoop/36383 has been created
Running in developer mode
[Tue Jul 28 01:54:41 JST 2015 DEBUG]: Importing
/Users/sekikn/hadoop/dev-support/test-patch.d/asflicense.sh
[Tue Jul 28 01:54:41 JST 2015 DEBUG]: Testing against asflicense
[Tue Jul 28 01:54:41 JST 2015 DEBUG]: Setting tests to asflicense
[Tue Jul 28 01:54:41 JST 2015 DEBUG]: Importing
/Users/sekikn/hadoop/dev-support/test-patch.d/builtin-personality.sh
[Tue Jul 28 01:54:41 JST 2015 DEBUG]: Importing
/Users/sekikn/hadoop/dev-support/test-patch.d/checkstyle.sh
[Tue Jul 28 01:54:41 JST 2015 DEBUG]: Importing
/Users/sekikn/hadoop/dev-support/test-patch.d/findbugs.sh
[Tue Jul 28 01:54:41 JST 2015 DEBUG]: Importing
/Users/sekikn/hadoop/dev-support/test-patch.d/github.sh
[Tue Jul 28 01:54:41 JST 2015 DEBUG]: Importing
/Users/sekikn/hadoop/dev-support/test-patch.d/jira.sh
[Tue Jul 28 01:54:41 JST 2015 DEBUG]: Importing
/Users/sekikn/hadoop/dev-support/test-patch.d/pylint.sh
[Tue Jul 28 01:54:41 JST 2015 DEBUG]: Importing
/Users/sekikn/hadoop/dev-support/test-patch.d/shellcheck.sh
[Tue Jul 28 01:54:41 JST 2015 DEBUG]: Importing
/Users/sekikn/hadoop/dev-support/test-patch.d/whitespace.sh
[Tue Jul 28 01:54:41 JST 2015 DEBUG]: Importing
/Users/sekikn/hadoop/dev-support/test-patch.d/xml.sh
[Tue Jul 28 01:54:41 JST 2015 DEBUG]: Importing
/Users/sekikn/hadoop/dev-support/personality/hadoop.sh
[Tue Jul 28 01:54:41 JST 2015 DEBUG]: Running findbugs_parse_args
[Tue Jul 28 01:54:41 JST 2015 DEBUG]: Running pylint_parse_args
[Tue Jul 28 01:54:41 JST 2015 DEBUG]: Running jira_parse_args
[Tue Jul 28 01:54:41 JST 2015 DEBUG]: locate patch
Patch file /tmp/test.patch copied to /private/tmp/test-patch-hadoop/36383
============================================================================
============================================================================
Confirming git environment
============================================================================
============================================================================
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Determine branch
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Determine branch: starting with
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Determine branch: ISSUE.branch.##.patch
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Determine branch: ISSUE-branch-##.patch
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Determine branch: ISSUE-##.patch.branch
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Determine branch: ISSUE-branch.##.patch
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Determine branch: starting with
/tmp/test.patch
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Determine branch: ISSUE.branch.##.patch
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Determine branch: ISSUE-branch-##.patch
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Determine branch: ISSUE-##.patch.branch
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Determine branch: ISSUE-branch.##.patch
WARNING: Current git branch is HADOOP-12111 but patch is built for trunk.
WARNING: Continuing anyway...
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Determine issue
Testing patch on HADOOP-12111.
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Determining needed tests for
hadoop-mapreduce-project/dev-support/findbugs-exclude.xml
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Using builtin mvn personality_file_tests
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Testing against findbugs
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Adding findbugs
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Testing against xml
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Adding xml
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Running find_java_home
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Start clock
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Running verify_patch_file
Patch file /private/tmp/test-patch-hadoop/36383/patch copied to
/tmp/apply-patch-11995.32371
Verifying the patch:
git apply --binary -v --check -p1 /private/tmp/test-patch-hadoop/36383/patch
Checking patch hadoop-mapreduce-project/dev-support/findbugs-exclude.xml...
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Checking skipdirs for
hadoop-mapreduce-project/dev-support
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Skipping skipdirs
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Find pom.xml dir for:
hadoop-mapreduce-project/dev-support
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Found: hadoop-mapreduce-project
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Locate the union of
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Only one entry, so keeping it
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Running precheck_without_patch
============================================================================
============================================================================
Verifying mvn install works
============================================================================
============================================================================
This patch does not appear to need mvn install checks.
============================================================================
============================================================================
Pre-patch HADOOP-12111 javac compilation
============================================================================
============================================================================
Patch does not appear to need javac tests.
============================================================================
============================================================================
Pre-patch HADOOP-12111 Javadoc verification
============================================================================
============================================================================
Patch does not appear to need javadoc tests.
============================================================================
============================================================================
Pre-patch HADOOP-12111 site verification
============================================================================
============================================================================
Patch does not appear to need site tests.
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Running check_author
============================================================================
============================================================================
Checking there are no @author tags in the patch.
============================================================================
============================================================================
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Start clock
There appear to be 0 @author tags in the patch.
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Stop clock
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: add_vote_table +1 @author The patch does
not contain any @author tags.
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Running check_modified_unittests
============================================================================
============================================================================
Checking there are new or changed tests in the patch.
============================================================================
============================================================================
Patch does not appear to need new or modified tests.
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Running checkstyle_preapply
============================================================================
============================================================================
HADOOP-12111 checkstyle
============================================================================
============================================================================
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Start clock
Patch does not need checkstyle testing.
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Running findbugs_preapply
============================================================================
============================================================================
Pre-patch findbugs detection
============================================================================
============================================================================
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Personality: branch findbugs
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Personality: clear queue
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: hmm in: normal
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: hmm expanded to:
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: hmm pre-ordering:
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: hmm out:
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: MultiJDK not configured.
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Running pylint_preapply
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Running shellcheck_preapply
============================================================================
============================================================================
Applying patch
============================================================================
============================================================================
Patch file /private/tmp/test-patch-hadoop/36383/patch copied to
/tmp/apply-patch-11029.14057
Verifying the patch:
git apply --binary -v --check -p1 /private/tmp/test-patch-hadoop/36383/patch
Checking patch hadoop-mapreduce-project/dev-support/findbugs-exclude.xml...
Applying the patch:
git apply --binary -v --stat --apply -p1
/private/tmp/test-patch-hadoop/36383/patch
Applied patch hadoop-mapreduce-project/dev-support/findbugs-exclude.xml cleanly.
.../dev-support/findbugs-exclude.xml | 1 -
1 file changed, 1 deletion(-)
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Checking skipdirs for
hadoop-mapreduce-project/dev-support
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Skipping skipdirs
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Find pom.xml dir for:
hadoop-mapreduce-project/dev-support
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Found: hadoop-mapreduce-project
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Locate the union of
[Tue Jul 28 01:54:42 JST 2015 DEBUG]: Only one entry, so keeping it
============================================================================
============================================================================
Determining number of patched javac errors
============================================================================
============================================================================
Patch does not appear to need javac tests.
[Tue Jul 28 01:54:43 JST 2015 DEBUG]: Running check_site
============================================================================
============================================================================
Determining number of patched site errors
============================================================================
============================================================================
Patch does not appear to need site tests.
[Tue Jul 28 01:54:43 JST 2015 DEBUG]: Running asflicense_postapply
============================================================================
============================================================================
Determining number of patched ASF License errors
============================================================================
============================================================================
[Tue Jul 28 01:54:43 JST 2015 DEBUG]: Start clock
[Tue Jul 28 01:54:43 JST 2015 DEBUG]: Personality: patch asflicense
[Tue Jul 28 01:54:43 JST 2015 DEBUG]: Personality: clear queue
[Tue Jul 28 01:54:43 JST 2015 DEBUG]: Personality: enqueue .
[Tue Jul 28 01:54:43 JST 2015 DEBUG]: MultiJDK not configured.
[Tue Jul 28 01:54:43 JST 2015 DEBUG]: Start clock
cd /Users/sekikn/dev/hadoop
mvn --batch-mode apache-rat:check -Ptest-patch >
/private/tmp/test-patch-hadoop/36383/patch-asflicense-root.txt 2>&1
[Tue Jul 28 01:55:09 JST 2015 DEBUG]: Stop clock
Elapsed: 0m 26s
[Tue Jul 28 01:55:09 JST 2015 DEBUG]: Stop clock
[Tue Jul 28 01:55:09 JST 2015 DEBUG]: add_vote_table 1 asflicense Patch does
not generate ASF License warnings.
[Tue Jul 28 01:55:09 JST 2015 DEBUG]: Running checkstyle_postapply
============================================================================
============================================================================
Patch checkstyle plugin
============================================================================
============================================================================
[Tue Jul 28 01:55:09 JST 2015 DEBUG]: Start clock
Patch does not need checkstyle testing.
[Tue Jul 28 01:55:09 JST 2015 DEBUG]: Running pylint_postapply
[Tue Jul 28 01:55:09 JST 2015 DEBUG]: Running shellcheck_postapply
[Tue Jul 28 01:55:09 JST 2015 DEBUG]: Running whitespace_postapply
============================================================================
============================================================================
Checking for whitespace at the end of lines
============================================================================
============================================================================
[Tue Jul 28 01:55:09 JST 2015 DEBUG]: Start clock
[Tue Jul 28 01:55:09 JST 2015 DEBUG]: Stop clock
[Tue Jul 28 01:55:09 JST 2015 DEBUG]: add_vote_table +1 whitespace Patch has no
whitespace issues.
[Tue Jul 28 01:55:09 JST 2015 DEBUG]: Running xml_postapply
============================================================================
============================================================================
Checking if XML files are well-formed
============================================================================
============================================================================
[Tue Jul 28 01:55:09 JST 2015 DEBUG]: Start clock
[Tue Jul 28 01:55:10 JST 2015 DEBUG]: Stop clock
[Tue Jul 28 01:55:10 JST 2015 DEBUG]: add_vote_table +1 xml The patch has no
ill-formed XML file.
============================================================================
============================================================================
Verifying mvn install still works
============================================================================
============================================================================
This patch does not appear to need mvn install checks.
[Tue Jul 28 01:55:10 JST 2015 DEBUG]: Running check_patch_javadoc
============================================================================
============================================================================
Determining number of patched javadoc warnings
============================================================================
============================================================================
Patch does not appear to need javadoc tests.
[Tue Jul 28 01:55:10 JST 2015 DEBUG]: Running check_mvn_eclipse
============================================================================
============================================================================
Verifying mvn eclipse:eclipse still works
============================================================================
============================================================================
Patch does not touch any java files. Skipping mvn eclipse:eclipse
[Tue Jul 28 01:55:10 JST 2015 DEBUG]: Running findbugs_postinstall
============================================================================
============================================================================
Patch findbugs detection
============================================================================
============================================================================
[Tue Jul 28 01:55:10 JST 2015 DEBUG]: Personality: patch findbugs
[Tue Jul 28 01:55:10 JST 2015 DEBUG]: Personality: clear queue
[Tue Jul 28 01:55:10 JST 2015 DEBUG]: hmm in: normal
[Tue Jul 28 01:55:10 JST 2015 DEBUG]: hmm expanded to:
[Tue Jul 28 01:55:10 JST 2015 DEBUG]: hmm pre-ordering:
[Tue Jul 28 01:55:10 JST 2015 DEBUG]: hmm out:
[Tue Jul 28 01:55:10 JST 2015 DEBUG]: MultiJDK not configured.
[Tue Jul 28 01:55:10 JST 2015 DEBUG]: MultiJDK not configured.
[Tue Jul 28 01:55:10 JST 2015 DEBUG]: Start clock
[Tue Jul 28 01:55:10 JST 2015 DEBUG]: Stop clock
[Tue Jul 28 01:55:10 JST 2015 DEBUG]: add_vote_table +1 findbugs the patch
passed
[Tue Jul 28 01:55:10 JST 2015 DEBUG]: Stop global clock
Total Elapsed time: 0m 29s
-1 overall
_____ _ _ _
| ___|_ _(_) |_ _ _ __ ___| |
| |_ / _` | | | | | | '__/ _ \ |
| _| (_| | | | |_| | | | __/_|
|_| \__,_|_|_|\__,_|_| \___(_)
| Vote | Subsystem | Runtime | Comment
============================================================================
| +1 | @author | 0m 00s | The patch does not contain any @author
| | | | tags.
| +1 | asflicense | 0m 26s | Patch does not generate ASF License
| | | | warnings.
| +1 | whitespace | 0m 00s | Patch has no whitespace issues.
| +1 | xml | 0m 01s | The patch has no ill-formed XML file.
| +1 | findbugs | 0m 00s | the patch passed
| | | 0m 29s |
|| Subsystem || Report/Notes ||
============================================================================
| git revision | HADOOP-12111 / 8d6dbbb |
| Optional Tests | asflicense findbugs xml |
| uname | Darwin mobile.local 14.4.0 Darwin Kernel Version 14.4.0: Thu May 28
11:35:04 PDT 2015; root:xnu-2782.30.5~1/RELEASE_X86_64 x86_64 |
| Build tool | maven |
| Personality | /Users/sekikn/hadoop/dev-support/personality/hadoop.sh |
| Default Java | 1.7.0_80 |
| Max memory used | 44MB |
============================================================================
============================================================================
Finished build.
============================================================================
============================================================================
{code}
> test-patch.sh should run findbugs if ony findbugs-exclude.xml has changed
> -------------------------------------------------------------------------
>
> Key: HADOOP-12254
> URL: https://issues.apache.org/jira/browse/HADOOP-12254
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: yetus
> Affects Versions: HADOOP-12111
> Reporter: Varun Saxena
> Attachments: HADOOP-12254.HADOOP-12111.00.patch
>
>
> Refer to Hadoop QA report for YARN-3952
> https://issues.apache.org/jira/browse/YARN-3952?focusedCommentId=14636455&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14636455
> We can run findbugs for all the submodules if findbugs-exclude.xml has been
> changed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
