[
https://issues.apache.org/jira/browse/HADOOP-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14647662#comment-14647662
]
Kengo Seki commented on HADOOP-12266:
-------------------------------------
bq. Negative votes still have the version in them.
I reconsidered it, and now I'm thinking there seems no problem if we always
show the version info. Sometimes it's useful even if negative votes cast,
because the found problem might be a false alarm caused by the old-versioned
validator (like shellcheck).
It may be ideal if we could suppress the version info only if the validator
abends, but both of pylint and shellcheck return the status greater than zero
when they find some problems in the code. It is difficult to distinguish them.
What do you think about it?
> make test-patch plugins more consistent
> ---------------------------------------
>
> Key: HADOOP-12266
> URL: https://issues.apache.org/jira/browse/HADOOP-12266
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: yetus
> Reporter: Kengo Seki
> Assignee: Kengo Seki
> Attachments: HADOOP-12266.HADOOP-12111.00.patch
>
>
> In response to:
> https://issues.apache.org/jira/browse/HADOOP-12207?focusedCommentId=14637515&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14637515
> * make *_calcdiffs to be a common function
> * move add_footer_table after all examinations finished
> * replace ${PATCH_BRANCH} in output filenames with "branch-"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
