[
https://issues.apache.org/jira/browse/HADOOP-12249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14648145#comment-14648145
]
Hadoop QA commented on HADOOP-12249:
------------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 40s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 37s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 39s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | shellcheck | 0m 5s | There were no new shellcheck
(v0.3.3) issues. |
| {color:green}+1{color} | whitespace | 0m 2s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 20s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 34s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | common tests | 22m 15s | Tests passed in
hadoop-common. |
| {color:green}+1{color} | common tests | 1m 38s | Tests passed in
hadoop-kms. |
| {color:green}+1{color} | hdfs tests | 161m 27s | Tests passed in hadoop-hdfs.
|
| {color:green}+1{color} | hdfs tests | 3m 38s | Tests passed in
hadoop-hdfs-httpfs. |
| | | 223m 21s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12748008/HADOOP-12294.01.patch |
| Optional Tests | javadoc javac unit shellcheck |
| git revision | trunk / ddc867ce |
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7373/artifact/patchprocess/testrun_hadoop-common.txt
|
| hadoop-kms test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7373/artifact/patchprocess/testrun_hadoop-kms.txt
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7373/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| hadoop-hdfs-httpfs test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7373/artifact/patchprocess/testrun_hadoop-hdfs-httpfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7373/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7373/console |
This message was automatically generated.
> pull argument parsing into a function
> -------------------------------------
>
> Key: HADOOP-12249
> URL: https://issues.apache.org/jira/browse/HADOOP-12249
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
> Affects Versions: 3.0.0
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Labels: scripts, shell
> Attachments: HADOOP-12249.00.patch, HADOOP-12294.01.patch
>
>
> In order to enable significantly better unit testing as well as enhanced
> functionality, large portions of *-config.sh should be pulled into functions.
> See first comment for more.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
