[
https://issues.apache.org/jira/browse/HADOOP-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14648160#comment-14648160
]
Colin Patrick McCabe commented on HADOOP-7824:
----------------------------------------------
Thanks, [~martinw]! It looks really good.
Just a few last nits:
* {{SET_INT_CONST}}: can we change this to {{SET_INT_OR_RETURN}}?
* {{setBooleanConstant}} / {{setIntConstant}} / etc. : can we change these to
{{setStaticBoolean}}, {{setStaticInt}}, etc.?
Two reasons:
* "Setting a constant" is just weird... by definition, constants can't be set
in C, so it feels confusing. These things are really static fields in the Java
class, not constants at all. (They're not Java constants-- those can't be
modified.)
* If a macro performs flow control, like returning from a function, it should
include that in the name to avoid confusion.
Avoid whitespace changes. For example, we don't need this:
{code}
- int fd;
+ int fd;
{code}
The git history is much nicer when changes are minimal. Related: do we even
need to change {{ReadaheadPool.java}}? It seems to just be adding a static
import.
+1 once those changes are addressed and Jenkins runs again. Thanks for working
on this.
> Native IO uses wrong constants almost everywhere
> ------------------------------------------------
>
> Key: HADOOP-7824
> URL: https://issues.apache.org/jira/browse/HADOOP-7824
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: native
> Affects Versions: 0.20.204.0, 0.20.205.0, 1.0.3, 0.23.0, 2.0.0-alpha, 3.0.0
> Environment: Mac OS X, Linux, Solaris, Windows, ...
> Reporter: Dmytro Shteflyuk
> Assignee: Martin Walsh
> Labels: hadoop
> Fix For: 2.8.0
>
> Attachments: HADOOP-7824.001.patch, HADOOP-7824.002.patch,
> HADOOP-7824.003.patch, HADOOP-7824.patch, HADOOP-7824.patch, hadoop-7824.txt
>
>
> Constants like O_CREAT, O_EXCL, etc. have different values on OS X and many
> other operating systems.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
