[ 
https://issues.apache.org/jira/browse/HADOOP-12314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694423#comment-14694423
 ] 

Kengo Seki commented on HADOOP-12314:
-------------------------------------

Other concern: modules_workers can increase $result, but $result is not 
declared as a local variable in this function, so global $result seems not to 
be cleared and to keep increasing over its invocations. Is this an expected 
behaviour?

check_mvn_eclipse also does not declare local $result, but it's not a big 
problem because this function is called only once for each run and set $? to 
$result directly.

> check_unittests in test-patch.sh can return a wrong status
> ----------------------------------------------------------
>
>                 Key: HADOOP-12314
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12314
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: yetus
>    Affects Versions: HADOOP-12111
>            Reporter: Kengo Seki
>
> Follow-up from HADOOP-12247. check_unittests returns the value of  
> $\{result}, but the status of *_process_tests is added to $\{results}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to