[ https://issues.apache.org/jira/browse/HADOOP-12295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694910#comment-14694910 ]
Yi Liu commented on HADOOP-12295: --------------------------------- Thanks [~vinayrpet] for the review, committed to trunk and branch-2. I can address the comment if Chris has, thanks. > Improve NetworkTopology#InnerNode#remove logic > ---------------------------------------------- > > Key: HADOOP-12295 > URL: https://issues.apache.org/jira/browse/HADOOP-12295 > Project: Hadoop Common > Issue Type: Improvement > Reporter: Yi Liu > Assignee: Yi Liu > Attachments: HADOOP-12295.001.patch > > > In {{NetworkTopology#InnerNode#remove}}, We can use {{childrenMap}} to get > the parent node, no need to loop the {{children}} list. Then it is more > efficient since in most cases deleting parent node doesn't happen. > Another nit in current code is: > {code} > String parent = n.getNetworkLocation(); > String currentPath = getPath(this); > {code} > can be in closure of {{\!isAncestor\(n\)}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)