[
https://issues.apache.org/jira/browse/HADOOP-12129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698099#comment-14698099
]
Allen Wittenauer edited comment on HADOOP-12129 at 8/15/15 4:22 AM:
--------------------------------------------------------------------
So I've found an interesting bug, but frankly, it's too hard to fix and a lot
of it goes back to the brokenness of the github API.
If a file has been modified in two different commits to the point that they
show up as different entries even in the github UI, then our comment on the
line is going to be probably on the wrong line, if the github API even accepts
it. The *only* way to fix this is to figure out which commit id hash applies
to which line change.
A good workaround is really to recommend people to rebase the changes to be in
as few commits as possible.
was (Author: aw):
So I've found an interesting bug, but frankly, it's too hard to fix and a lot
of it goes back to the brokenness of the github API.
If a file has been modified in two different commits to the point that they
show up as different entries even in the github UI, then our comment on the
line is going to be probably on the wrong line. The *only* way to fix this is
to figure out which commit id hash applies to which line change.
A good workaround is really to recommend people to rebase the changes to be in
as few commits as possible.
> rework test-patch bug system support
> ------------------------------------
>
> Key: HADOOP-12129
> URL: https://issues.apache.org/jira/browse/HADOOP-12129
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: yetus
> Affects Versions: HADOOP-12111
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Priority: Blocker
> Attachments: HADOOP-12129.HADOOP-12111.00.patch,
> HADOOP-12129.HADOOP-12111.01.patch, HADOOP-12129.HADOOP-12111.02.patch,
> HADOOP-12129.HADOOP-12111.03.patch, HADOOP-12129.HADOOP-12111.04.patch
>
>
> WARNING: this is a fairly big project.
> See first comment for a brain dump on the issues.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
