[
https://issues.apache.org/jira/browse/HADOOP-12303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698750#comment-14698750
]
Hadoop QA commented on HADOOP-12303:
------------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} precommit patch detected. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
28s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:red}-1{color} | {color:red} shellcheck {color} | {color:red} 0m 6s
{color} | {color:red} The applied patch generated 2 new shellcheck issues
(total was 20, now 22). {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 0m 38s {color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12750709/HADOOP-12303.HADOOP-12111.00.patch
|
| git revision | HADOOP-12111 / 565d9bf |
| Optional Tests | asflicense unit shellcheck |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/dev-support-test/personality/hadoop.sh
|
| Default Java | 1.7.0_55 |
| Multi-JDK versions | /home/jenkins/tools/java/jdk1.8.0:1.8.0
/home/jenkins/tools/java/jdk1.7.0_55:1.7.0_55 |
| shellcheck | v0.3.3 (This is an old version that has serious bugs. Consider
upgrading.) |
| shellcheck |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7486/artifact/patchprocess/diff-patch-shellcheck.txt
|
| JDK v1.7.0_55 Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7486/testReport/ |
| Max memory used | 49MB |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7486/console |
This message was automatically generated.
> test-patch pylint plugin fails silently and votes +1 incorrectly
> ----------------------------------------------------------------
>
> Key: HADOOP-12303
> URL: https://issues.apache.org/jira/browse/HADOOP-12303
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: yetus
> Affects Versions: HADOOP-12111
> Reporter: Kengo Seki
> Assignee: Kengo Seki
> Attachments: HADOOP-12303.HADOOP-12111.00.patch
>
>
> This patch
> {code}
> [sekikn@mobile hadoop]$ cat /tmp/test.patch
> diff --git a/dev-support/releasedocmaker.py b/dev-support/releasedocmaker.py
> index 37bd58a..7cd6dd3 100755
> --- a/dev-support/releasedocmaker.py
> +++ b/dev-support/releasedocmaker.py
> @@ -580,4 +580,4 @@ def main():
> sys.exit(1)
>
> if __name__ == "__main__":
> - main()
> + main( )
> {code}
> is supposed to cause the following pylint errors.
> {code}
> C:583, 0: No space allowed after bracket
> main( )
> ^ (bad-whitespace)
> C:583, 0: No space allowed before bracket
> main( )
> ^ (bad-whitespace)
> {code}
> But the system locale is set as follows, pylint check is passed, and there is
> no pylint output.
> {code}
> [sekikn@mobile hadoop]$ locale
> LANG=
> LC_COLLATE="C"
> LC_CTYPE="UTF-8"
> LC_MESSAGES="C"
> LC_MONETARY="C"
> LC_NUMERIC="C"
> LC_TIME="C"
> LC_ALL=
> [sekikn@mobile hadoop]$ dev-support/test-patch.sh
> --basedir=/Users/sekikn/dev/hadoop --project=hadoop /tmp/test.patch
> (snip)
> | Vote | Subsystem | Runtime | Comment
> ============================================================================
> | +1 | @author | 0m 00s | The patch does not contain any @author
> | | | | tags.
> | +1 | asflicense | 0m 21s | Patch does not generate ASF License
> | | | | warnings.
> | +1 | pylint | 0m 01s | There were no new pylint issues.
> | +1 | whitespace | 0m 00s | Patch has no whitespace issues.
> | | | 0m 24s |
> (snip)
> [sekikn@mobile hadoop]$ cat
> /private/tmp/test-patch-hadoop/8656/branch-pylint-result.txt
> [sekikn@mobile hadoop]$ cat
> /private/tmp/test-patch-hadoop/8656/patch-pylint-result.txt
> [sekikn@mobile hadoop]$ cat
> /private/tmp/test-patch-hadoop/8656/diff-patch-pylint.txt
> {code}
> Removing '2>/dev/null' from pylint.sh reveals the root cause. Setting LC_ALL
> or LC_CTYPE such like 'en_US.UTF-8' solves this problem.
> {code}
> ============================================================================
> ============================================================================
> pylint plugin: prepatch
> ============================================================================
> ============================================================================
> ============================================================================
> Running pylint against modified python scripts.
> No config file found, using default configuration
> Traceback (most recent call last):
> File "/usr/local/bin/pylint", line 11, in <module>
> sys.exit(run_pylint())
> File "/Library/Python/2.7/site-packages/pylint/__init__.py", line 23, in
> run_pylint
> Run(sys.argv[1:])
> File "/Library/Python/2.7/site-packages/pylint/lint.py", line 1332, in
> __init__
> linter.check(args)
> File "/Library/Python/2.7/site-packages/pylint/lint.py", line 747, in check
> self._do_check(files_or_modules)
> File "/Library/Python/2.7/site-packages/pylint/lint.py", line 869, in
> _do_check
> self.check_astroid_module(ast_node, walker, rawcheckers, tokencheckers)
> File "/Library/Python/2.7/site-packages/pylint/lint.py", line 944, in
> check_astroid_module
> checker.process_tokens(tokens)
> File "/Library/Python/2.7/site-packages/pylint/checkers/format.py", line
> 743, in process_tokens
> self.check_indent_level(token, indents[-1]+1, line_num)
> File "/Library/Python/2.7/site-packages/pylint/checkers/format.py", line
> 963, in check_indent_level
> expected * unit_size))
> File "/Library/Python/2.7/site-packages/pylint/checkers/__init__.py", line
> 101, in add_message
> self.linter.add_message(msg_id, line, node, args, confidence)
> File "/Library/Python/2.7/site-packages/pylint/utils.py", line 410, in
> add_message
> (abspath, path, module, obj, line or 1, col_offset or 0), msg,
> confidence))
> File "/Library/Python/2.7/site-packages/pylint/reporters/text.py", line 61,
> in handle_message
> self.write_message(msg)
> File "/Library/Python/2.7/site-packages/pylint/reporters/text.py", line 51,
> in write_message
> self.writeln(msg.format(self._template))
> File "/Library/Python/2.7/site-packages/pylint/reporters/__init__.py", line
> 94, in writeln
> print(self.encode(string), file=self.out)
> File "/Library/Python/2.7/site-packages/pylint/reporters/__init__.py", line
> 84, in encode
> locale.getdefaultlocale()[1] or
> File
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/locale.py",
> line 511, in getdefaultlocale
> return _parse_localename(localename)
> File
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/locale.py",
> line 443, in _parse_localename
> raise ValueError, 'unknown locale: %s' % localename
> ValueError: unknown locale: UTF-8
> {code}
> In such a case, pylint plugin should fail and vote -1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
