[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709595#comment-14709595
]
Ravi Prakash commented on HADOOP-10949:
---------------------------------------
1. {{dateFormat}} and {{timeFormat}} can be static final members of KafkaSink.
2. Any reason you want to initialize {{hostname}} on every {{putMetrics()}}?
3. Please conform to Hadoop coding style and fix indentation: {code}
ProducerRecord<Integer, byte[]> data
= new ProducerRecord<Integer, byte[]>(
topic,
jsonLines.toString().getBytes());
{code}
4. Please document the expected behavior of the KafkaProducer in putMetrics(),
of putMetrics and also an example record json.
5. {{flush()}} could be a synchronous send() of an empty record or it should
throw a MetricsException too IMHO.
6. Please document the test. Please follow the coding style guide for the test
as well.
> Write metrics2 sink plugin for Apache Kafka -- KafkaSink
> --------------------------------------------------------
>
> Key: HADOOP-10949
> URL: https://issues.apache.org/jira/browse/HADOOP-10949
> Project: Hadoop Common
> Issue Type: New Feature
> Components: metrics
> Reporter: Babak Behzad
> Assignee: Babak Behzad
> Attachments: HADOOP-10949-1.patch, HADOOP-10949-2.patch,
> HADOOP-10949.patch, HADOOP-10949.patch, HADOOP-10949.patch,
> HADOOP-10949.patch, HADOOP-10949.patch, HADOOP-10949.patch,
> HADOOP-10949.patch, HADOOP-10949.patch, HADOOP-10949.patch,
> HADOOP-10949.patch, HADOOP-10949.patch
>
>
> Write a metrics2 sink plugin for Hadoop to send metrics directly to Apache
> Kafka in addition to the current, Graphite
> ([Hadoop-9704|https://issues.apache.org/jira/browse/HADOOP-9704]), Ganglia
> and File sinks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
