[
https://issues.apache.org/jira/browse/HADOOP-12354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14711589#comment-14711589
]
Kengo Seki commented on HADOOP-12354:
-------------------------------------
I think it isn't. After applying HADOOP-12336.HADOOP-12111.00.patch,
github_find_jira_title is still as follows:
{code}
function github_find_jira_title
{
declare title
declare maybe
declare retval
if [[ ! -f "${PATCH_DIR}/github-pull.json" ]]; then
return 1
fi
title=$(GREP title "${PATCH_DIR}/github-pull.json" \
| cut -f4 -d\")
# people typically do two types: JIRA-ISSUE: and [JIRA-ISSUE]
# JIRA_ISSUE_RE is pretty strict so we need to chop that stuff
# out first
maybe=$(echo "${title}" | cut -f2 -d\[ | cut -f1 -d\])
jira_determine_issue "${maybe}"
retval=$?
if [[ ${retval} == 0 ]]; then
return 0
fi
maybe=$(echo "${title}" | cut -f1 -d:)
jira_determine_issue "${maybe}"
retval=$?
if [[ ${retval} == 0 ]]; then
return 0
fi
}
{code}
Should it return other than 0 if both invocations of jira_determine_issue fail?
> github_find_jira_title in test-patch github plugin returns 0 even if
> jira_determine_issue failed
> ------------------------------------------------------------------------------------------------
>
> Key: HADOOP-12354
> URL: https://issues.apache.org/jira/browse/HADOOP-12354
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: yetus
> Affects Versions: HADOOP-12111
> Reporter: Kengo Seki
>
> So the following check for $\{GITHUB_ISSUE} seems to be skipped and
> github_determine_issue seems to succeed almost always.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
