[
https://issues.apache.org/jira/browse/HADOOP-12360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14717210#comment-14717210
]
Dave Marion commented on HADOOP-12360:
--------------------------------------
Patch 3 addresses the issues below
bq. use NetUtils methods to get the hostname
done
bq. logging: you can use the SLF4J APIs and so skip the log level condition
wrappers; use debug() instead of trace() as log4j combines them anyway.
done
bq. you can use j7 <> types in constructors now
Not sure what you mean by this
bq. exception catch clause in connect() should only catch IOException unless
there's some special reason otherwise
OBE - your comment about connection failure reminded me that this is a UDP
client. There is no stateful connection; it's fire and forget, even if it
fails. I fixed the StatsD class to reflect this, which means connect() and the
connection failure logic was removed. Having said that, I copied the logic from
the Graphite sink. If it's wrong here, then it's wrong there also.
bq. inner statsd class should be private
I can do this if you can give me a good way to instantiate the class in the
tests
bq. the tests must have a timeout attribute so timing out operations (here:
receive()) have timeouts handled in the test runner, not a brute force jvm kill
done
bq. socket close() must be in finally clause, so that failed tests clean up
done
> Create StatsD metrics2 sink
> ---------------------------
>
> Key: HADOOP-12360
> URL: https://issues.apache.org/jira/browse/HADOOP-12360
> Project: Hadoop Common
> Issue Type: New Feature
> Components: metrics
> Affects Versions: 2.7.1
> Reporter: Dave Marion
> Assignee: Dave Marion
> Priority: Minor
> Attachments: HADOOP-12360.001.patch, HADOOP-12360.002.patch,
> HADOOP-12360.003.patch
>
>
> Create a metrics sink that pushes to a StatsD daemon.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
