[
https://issues.apache.org/jira/browse/HADOOP-11887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14720772#comment-14720772
]
Colin Patrick McCabe commented on HADOOP-11887:
-----------------------------------------------
Sorry for the hiatus. I was on vacation recently. It looks like the two most
recent patch files have the same name, {{HADOOP-11887-v5.patch}}. I am
reviewing the August 10 one.
This looks good overall! Thanks for updating the bundle.snappy, bundle.openssl
etc checks in {{hadoop-project-dist/pom.xml}} to use safe shell string
comparisons.
{{hadoop-common-project/hadoop-common/src/CMakeLists.txt}}: The D variable has
been removed in trunk, you have to use SRC now here.
{{ErasureCodeNative.java}}: Could rephrase "ISA-L isn't supported in the
building" as "libhadoop was built without ISA-L support"
{{ErasureCodeNative.java}}: In the JavaDoc comment, {{Is the native ISA-L
library loaded & initialized? Throw exception if not.}}, the ampersand is
likely to cause problems with Javadoc. It might be easier to replace it with
"and" (or you could escape it... I think JavaDoc uses HTML escapes or something
like that.)
{{io/erasurecode/erasure_code_test.c}}: It's nice that we can now run the test
through Java, but it looks like this test code is getting linked into
{{libhadoop.so}} and would be deployed in production. We generally avoid
pulling in test code to production where possible, because it increases code
size and may pull in dependencies or add extra APIs, etc. You should be able
to use the native unit test stuff to avoid this. See
{{hadoop-hdfs-project/hadoop-hdfs/pom.xml}} -- specifically the section on
{{test_libhdfs_threaded}} and {{test_native_mini_dfs}} for an example of this.
Looks good, should be ready to go aside from that!
> Introduce Intel ISA-L erasure coding library for the native support
> -------------------------------------------------------------------
>
> Key: HADOOP-11887
> URL: https://issues.apache.org/jira/browse/HADOOP-11887
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: io
> Reporter: Kai Zheng
> Assignee: Kai Zheng
> Attachments: HADOOP-11887-v1.patch, HADOOP-11887-v2.patch,
> HADOOP-11887-v3.patch, HADOOP-11887-v4.patch, HADOOP-11887-v5.patch,
> HADOOP-11887-v5.patch
>
>
> This is to introduce Intel ISA-L erasure coding library for the native
> support, via dynamic loading mechanism (dynamic module, like *.so in *nix and
> *.dll on Windows).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
