[
https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14726208#comment-14726208
]
Andrew Wang commented on HADOOP-12358:
--------------------------------------
Patch looks good overall, thanks for discussion everyone. Good point about the
# RPCs, I was looking at FileSystem rather than DFS. Patch-wise I have a few
nits, otherwise LGTM though:
* Unrelated whitespace change in Trash.java
* Can we rename checkDeleteLimit to be canBeSafelyDeleted or something? I think
that's more descriptive.
* Maybe add comment to help text about potential performance impact of the
-safely flag
Since this is opt-in via the new flag, I'm okay putting it in even if
getContentSummary is a bit expensive.
> FSShell should prompt before deleting directories bigger than a configured
> size
> -------------------------------------------------------------------------------
>
> Key: HADOOP-12358
> URL: https://issues.apache.org/jira/browse/HADOOP-12358
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Xiaoyu Yao
> Assignee: Xiaoyu Yao
> Attachments: HADOOP-12358.00.patch, HADOOP-12358.01.patch,
> HADOOP-12358.02.patch, HADOOP-12358.03.patch, HADOOP-12358.04.patch,
> HADOOP-12358.05.patch, HADOOP-12358.06.patch
>
>
> We have seen many cases with customers deleting data inadvertently with
> -skipTrash. The FSShell should prompt user if the size of the data or the
> number of files being deleted is bigger than a threshold even though
> -skipTrash is being used.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
