[ 
https://issues.apache.org/jira/browse/HADOOP-12296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14727710#comment-14727710
 ] 

Jason Lowe commented on HADOOP-12296:
-------------------------------------

Latest patch looks good, at least from the Linux perspective.  Can anyone 
comment on the other architectures that are returning a value from setnetgrent? 
 Seems to me that we would want to report an error for the other architectures 
that are returning an error, otherwise we are silently _not_ loading anything 
for the netgroup on those platforms.  As I mentioned above, the only difference 
in practice is whether we log a message when this occurs or not, so I think we 
should remove the __linux__ check.  Thoughts?

> when setnetgrent returns 0 in linux, exception should be thrown
> ---------------------------------------------------------------
>
>                 Key: HADOOP-12296
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12296
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Chang Li
>            Assignee: Chang Li
>         Attachments: HADOOP-12296.2.patch, HADOOP-12296.3.patch, 
> HADOOP-12296.3.patch, HADOOP-12296.patch
>
>
> In linux, setnetgrent returns 0 in linux when something wrong is happen, such 
> as out of memory, unknown group, unavailable service, etc. So errorMessage 
> should be set and exception should be thrown



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to